Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upComponents: Extract TableOfContents as reusable component #3639
Conversation
youknowriad
self-assigned this
Nov 24, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
youknowriad
Nov 24, 2017
Contributor
Expect some similar PRs today, I'm going to merge them as soon as the tests pass, they consist of moving some files around.
|
Expect some similar PRs today, I'm going to merge them as soon as the tests pass, they consist of moving some files around. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
codecov
Nov 24, 2017
Codecov Report
Merging #3639 into master will increase coverage by
0.04%.
The diff coverage is0%.
@@ Coverage Diff @@
## master #3639 +/- ##
==========================================
+ Coverage 36.8% 36.85% +0.04%
==========================================
Files 268 268
Lines 6649 6640 -9
Branches 1201 1201
==========================================
Hits 2447 2447
+ Misses 3550 3541 -9
Partials 652 652| Impacted Files | Coverage Δ | |
|---|---|---|
| editor/components/table-of-contents/index.js | 0% <ø> (ø) |
|
| editor/edit-post/header/header-toolbar/index.js | 0% <0%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 7b19f4f...5d0cbdd. Read the comment docs.
codecov
commented
Nov 24, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #3639 +/- ##
==========================================
+ Coverage 36.8% 36.85% +0.04%
==========================================
Files 268 268
Lines 6649 6640 -9
Branches 1201 1201
==========================================
Hits 2447 2447
+ Misses 3550 3541 -9
Partials 652 652
Continue to review full report at Codecov.
|
youknowriad commentedNov 24, 2017
Extract a reusable TableOfContents to the
editor/componentsfolder.Needed to be able to separate the
edit-postandeditormoduleTesting instructions