Popover: allow scrolling over #23696
Merged
Conversation
| @@ -396,8 +391,7 @@ const Popover = ( { | |||
| setAnimateOrigin( animateXAxis + ' ' + animateYAxis ); | |||
| }; | |||
|
|
|||
| // Height may still adjust between now and the next tick. | |||
| const timeoutId = window.setTimeout( refresh ); | |||
|
Size Change: -983 B (0%) Total Size: 1.13 MB
|
| Filename | Size | Change | |
|---|---|---|---|
build/a11y/index.js |
1.14 kB | 0 B | |
build/annotations/index.js |
3.68 kB | 0 B | |
build/api-fetch/index.js |
3.4 kB | 0 B | |
build/autop/index.js |
2.82 kB | 0 B | |
build/blob/index.js |
620 B | 0 B | |
build/block-directory/style-rtl.css |
944 B | 0 B | |
build/block-directory/style.css |
945 B | 0 B | |
build/block-library/editor-rtl.css |
7.57 kB | 0 B | |
build/block-library/editor.css |
7.57 kB | 0 B | |
build/block-library/style-rtl.css |
7.78 kB | 0 B | |
build/block-library/style.css |
7.79 kB | 0 B | |
build/block-library/theme-rtl.css |
728 B | 0 B | |
build/block-library/theme.css |
729 B | 0 B | |
build/block-serialization-default-parser/index.js |
1.88 kB | 0 B | |
build/components/style-rtl.css |
15.8 kB | 0 B | |
build/components/style.css |
15.8 kB | 0 B | |
build/core-data/index.js |
11.4 kB | 0 B | |
build/data-controls/index.js |
1.29 kB | 0 B | |
build/data/index.js |
8.44 kB | 0 B | |
build/deprecated/index.js |
772 B | 0 B | |
build/dom-ready/index.js |
569 B | 0 B | |
build/dom/index.js |
3.19 kB | 0 B | |
build/edit-navigation/style-rtl.css |
1.02 kB | 0 B | |
build/edit-navigation/style.css |
1.02 kB | 0 B | |
build/edit-post/style-rtl.css |
5.57 kB | 0 B | |
build/edit-post/style.css |
5.57 kB | 0 B | |
build/edit-site/style-rtl.css |
3.03 kB | 0 B | |
build/edit-site/style.css |
3.03 kB | 0 B | |
build/edit-widgets/style-rtl.css |
2.45 kB | 0 B | |
build/edit-widgets/style.css |
2.45 kB | 0 B | |
build/editor/editor-styles-rtl.css |
537 B | 0 B | |
build/editor/editor-styles.css |
539 B | 0 B | |
build/editor/style-rtl.css |
3.78 kB | 0 B | |
build/editor/style.css |
3.77 kB | 0 B | |
build/element/index.js |
4.65 kB | 0 B | |
build/escape-html/index.js |
733 B | 0 B | |
build/format-library/index.js |
7.73 kB | 0 B | |
build/format-library/style-rtl.css |
547 B | 0 B | |
build/format-library/style.css |
548 B | 0 B | |
build/hooks/index.js |
2.13 kB | 0 B | |
build/html-entities/index.js |
622 B | 0 B | |
build/i18n/index.js |
3.56 kB | 0 B | |
build/is-shallow-equal/index.js |
710 B | 0 B | |
build/keyboard-shortcuts/index.js |
2.52 kB | 0 B | |
build/keycodes/index.js |
1.94 kB | 0 B | |
build/list-reusable-blocks/index.js |
3.12 kB | 0 B | |
build/list-reusable-blocks/style-rtl.css |
476 B | 0 B | |
build/list-reusable-blocks/style.css |
476 B | 0 B | |
build/notices/index.js |
1.79 kB | 0 B | |
build/nux/index.js |
3.41 kB | 0 B | |
build/nux/style-rtl.css |
671 B | 0 B | |
build/nux/style.css |
668 B | 0 B | |
build/plugins/index.js |
2.56 kB | 0 B | |
build/priority-queue/index.js |
788 B | 0 B | |
build/redux-routine/index.js |
2.85 kB | 0 B | |
build/shortcode/index.js |
1.69 kB | 0 B | |
build/token-list/index.js |
1.28 kB | 0 B | |
build/url/index.js |
4.06 kB | 0 B | |
build/viewport/index.js |
1.85 kB | 0 B | |
build/warning/index.js |
1.14 kB | 0 B | |
build/wordcount/index.js |
1.17 kB | 0 B |
ellatrix
force-pushed the
fix/popover-position-scroll
branch
3 times, most recently
from
317543f
to
8006b36
ellatrix
force-pushed the
fix/popover-position-scroll
branch
2 times, most recently
from
501a97d
to
96c0434
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Description
Enables scrolling the content while the pointer is over the block toolbar.
This PR reverts #19896. That fix is no longer necessary since popover height is no longer only calculated once (#23159) and the position is set with
useLayoutEffect(#23312), meaning we can set the popover top/left styles as soon as the component renders.How has this been tested?
Screenshots
Types of changes
Checklist: