Fix empty block list appender visibility on aligned blocks #23672
Conversation
Size Change: -4 B (0%) Total Size: 1.13 MB
|
Filename | Size | Change | |
---|---|---|---|
build/a11y/index.js |
1.14 kB | 0 B | |
build/annotations/index.js |
3.62 kB | 0 B | |
build/api-fetch/index.js |
3.4 kB | 0 B | |
build/autop/index.js |
2.82 kB | 0 B | |
build/blob/index.js |
620 B | 0 B | |
build/block-directory/index.js |
7.16 kB | 0 B | |
build/block-directory/style-rtl.css |
952 B | 0 B | |
build/block-directory/style.css |
951 B | 0 B | |
build/block-editor/index.js |
109 kB | 0 B | |
build/block-library/editor-rtl.css |
7.63 kB | 0 B | |
build/block-library/editor.css |
7.64 kB | 0 B | |
build/block-library/index.js |
130 kB | 0 B | |
build/block-library/style-rtl.css |
7.79 kB | 0 B | |
build/block-library/style.css |
7.79 kB | 0 B | |
build/block-library/theme-rtl.css |
730 B | 0 B | |
build/block-library/theme.css |
732 B | 0 B | |
build/block-serialization-default-parser/index.js |
1.88 kB | 0 B | |
build/block-serialization-spec-parser/index.js |
3.1 kB | 0 B | |
build/blocks/index.js |
48.2 kB | 0 B | |
build/components/index.js |
198 kB | 0 B | |
build/components/style-rtl.css |
15.9 kB | 0 B | |
build/components/style.css |
15.8 kB | 0 B | |
build/compose/index.js |
9.65 kB | 0 B | |
build/core-data/index.js |
11.4 kB | 0 B | |
build/data-controls/index.js |
1.29 kB | 0 B | |
build/data/index.js |
8.44 kB | 0 B | |
build/date/index.js |
5.47 kB | 0 B | |
build/deprecated/index.js |
772 B | 0 B | |
build/dom-ready/index.js |
569 B | 0 B | |
build/dom/index.js |
3.19 kB | 0 B | |
build/edit-navigation/index.js |
9.97 kB | 0 B | |
build/edit-navigation/style-rtl.css |
1.02 kB | 0 B | |
build/edit-navigation/style.css |
1.02 kB | 0 B | |
build/edit-post/index.js |
304 kB | 0 B | |
build/edit-post/style-rtl.css |
5.57 kB | 0 B | |
build/edit-post/style.css |
5.56 kB | 0 B | |
build/edit-site/index.js |
16.6 kB | 0 B | |
build/edit-site/style-rtl.css |
3.02 kB | 0 B | |
build/edit-site/style.css |
3.02 kB | 0 B | |
build/edit-widgets/index.js |
9.33 kB | 0 B | |
build/edit-widgets/style-rtl.css |
2.45 kB | 0 B | |
build/edit-widgets/style.css |
2.45 kB | 0 B | |
build/editor/editor-styles-rtl.css |
537 B | 0 B | |
build/editor/editor-styles.css |
539 B | 0 B | |
build/editor/index.js |
44.8 kB | 0 B | |
build/editor/style-rtl.css |
3.82 kB | 0 B | |
build/editor/style.css |
3.82 kB | 0 B | |
build/element/index.js |
4.65 kB | 0 B | |
build/escape-html/index.js |
733 B | 0 B | |
build/format-library/index.js |
7.73 kB | 0 B | |
build/format-library/style-rtl.css |
547 B | 0 B | |
build/format-library/style.css |
548 B | 0 B | |
build/hooks/index.js |
2.13 kB | 0 B | |
build/html-entities/index.js |
622 B | 0 B | |
build/i18n/index.js |
3.56 kB | 0 B | |
build/is-shallow-equal/index.js |
710 B | 0 B | |
build/keyboard-shortcuts/index.js |
2.51 kB | 0 B | |
build/keycodes/index.js |
1.94 kB | 0 B | |
build/list-reusable-blocks/index.js |
3.12 kB | 0 B | |
build/list-reusable-blocks/style-rtl.css |
476 B | 0 B | |
build/list-reusable-blocks/style.css |
476 B | 0 B | |
build/media-utils/index.js |
5.3 kB | 0 B | |
build/notices/index.js |
1.79 kB | 0 B | |
build/nux/index.js |
3.4 kB | 0 B | |
build/nux/style-rtl.css |
671 B | 0 B | |
build/nux/style.css |
668 B | 0 B | |
build/plugins/index.js |
2.56 kB | 0 B | |
build/primitives/index.js |
1.5 kB | 0 B | |
build/priority-queue/index.js |
788 B | 0 B | |
build/redux-routine/index.js |
2.85 kB | 0 B | |
build/rich-text/index.js |
14 kB | 0 B | |
build/server-side-render/index.js |
2.68 kB | 0 B | |
build/shortcode/index.js |
1.69 kB | 0 B | |
build/token-list/index.js |
1.28 kB | 0 B | |
build/url/index.js |
4.06 kB | 0 B | |
build/viewport/index.js |
1.85 kB | 0 B | |
build/warning/index.js |
1.14 kB | 0 B | |
build/wordcount/index.js |
1.17 kB | 0 B |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Description
Fixes #23665
The block list appender wasn't visible in the media and text block after deleting all inner blocks.
The issue was that the selector
![Screenshot 2020-07-03 at 4 43 14 pm](https://webcf.waybackmachine.org/web/20201221215335im_/https://user-images.githubusercontent.com/677833/86450555-5043b480-bd4c-11ea-805c-38df790d1fd7.png)
.wp-block:not(.is-selected):not(.has-child-selected)
was used to hide the appender when the block didn't have selection. Because the media text block is by default aligned,.wp-block
is applied to a separate wrapping element to.is-selected
:Resulting in this selector being triggered even when the block was selected.
Changing the selector to use
.block-editor-block-list__block
seems to resolve things.How has this been tested?
Screenshots
Before:
![Screenshot 2020-07-03 at 4 45 49 pm](https://webcf.waybackmachine.org/web/20201221215335im_/https://user-images.githubusercontent.com/677833/86451033-ebd52500-bd4c-11ea-98e1-9c5cc3e6f005.png)
After:
![Screenshot 2020-07-03 at 4 45 05 pm](https://webcf.waybackmachine.org/web/20201221215335im_/https://user-images.githubusercontent.com/677833/86451046-f099d900-bd4c-11ea-827d-d5f18dcbd4b6.png)
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: