Skip to content

/ gutenberg

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add modern color scheme. #23558

Merged
merged 1 commit into from Jul 2, 2020
Merged

Add modern color scheme. #23558

merged 1 commit into from Jul 2, 2020

Conversation

@jasmussen
Copy link
Contributor

@jasmussen jasmussen commented Jun 29, 2020

This is an addon PR to WordPress/wordpress-develop#369, which adds a new color scheme called "Modern". This PR simply treats that scheme as all the others, and add a new spot color for it.

There is a separate effort in https://core.trac.wordpress.org/ticket/49999 that aims to rewite in SCSS and refresh the existing color schemes. This effort could create one unified place for all color schemes in the core project itself. But in the mean time, this PR along with #369 brings an immediate contrast and consistency benefit to WordPress and the block editor, and is small enough that it could ship with 5.5.

Screenshot 2020-06-29 at 15 08 49

I will work on any followups to improve the SCSS bits.

Note that this PR should not be merged unless the trac ticket receives a blessing.
@jasmussen
Add modern color scheme.
Loading status checks…
640eed5
@jasmussen jasmussen requested review from youknowriad and ryelle Jun 29, 2020
@jasmussen jasmussen self-assigned this Jun 29, 2020
@jasmussen jasmussen mentioned this pull request Jun 29, 2020
Closed
@github-actions
Copy link

@github-actions github-actions bot commented Jun 29, 2020

Size Change: +204 B (0%)

Total Size: 1.13 MB

Filename Size Change
build/edit-post/style-rtl.css 5.53 kB +25 B (0%)
build/edit-post/style.css 5.53 kB +25 B (0%)
build/edit-site/style-rtl.css 3.06 kB +25 B (0%)
build/edit-site/style.css 3.06 kB +25 B (0%)
build/edit-widgets/style-rtl.css 2.45 kB +26 B (1%)
build/edit-widgets/style.css 2.45 kB +27 B (1%)
build/list-reusable-blocks/style-rtl.css 476 B +26 B (5%) 🔍
build/list-reusable-blocks/style.css 476 B +25 B (5%) 🔍
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.62 kB 0 B
build/api-fetch/index.js 3.4 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 7.39 kB 0 B
build/block-directory/style-rtl.css 941 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/index.js 109 kB 0 B
build/block-editor/style-rtl.css 10.7 kB 0 B
build/block-editor/style.css 10.7 kB 0 B
build/block-library/editor-rtl.css 7.6 kB 0 B
build/block-library/editor.css 7.6 kB 0 B
build/block-library/index.js 130 kB 0 B
build/block-library/style-rtl.css 8.04 kB 0 B
build/block-library/style.css 8.04 kB 0 B
build/block-library/theme-rtl.css 730 B 0 B
build/block-library/theme.css 732 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.2 kB 0 B
build/components/index.js 198 kB 0 B
build/components/style-rtl.css 15.9 kB 0 B
build/components/style.css 15.9 kB 0 B
build/compose/index.js 9.64 kB 0 B
build/core-data/index.js 11.4 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.44 kB 0 B
build/date/index.js 5.47 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 3.19 kB 0 B
build/edit-navigation/index.js 9.87 kB 0 B
build/edit-navigation/style-rtl.css 1.02 kB 0 B
build/edit-navigation/style.css 1.02 kB 0 B
build/edit-post/index.js 303 kB 0 B
build/edit-site/index.js 16.6 kB 0 B
build/edit-widgets/index.js 9.32 kB 0 B
build/editor/editor-styles-rtl.css 537 B 0 B
build/editor/editor-styles.css 539 B 0 B
build/editor/index.js 44.8 kB 0 B
build/editor/style-rtl.css 3.86 kB 0 B
build/editor/style.css 3.86 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.72 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 711 B 0 B
build/keyboard-shortcuts/index.js 2.51 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/media-utils/index.js 5.29 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 663 B 0 B
build/nux/style.css 660 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 788 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 14 kB 0 B
build/server-side-render/index.js 2.68 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action
@earnjam
Copy link
Contributor

@earnjam earnjam commented Jun 29, 2020

Maybe it's still early on this, and this is just my opinion, but the default link color and the new purplish-blue seem to clash.
image

image
@jasmussen
Copy link
Contributor Author

@jasmussen jasmussen commented Jun 29, 2020

I think that's completely valid, and I think those links should be the same blue color. Which I can make happen in the block editor, but for the core project it likely has to happen as part of https://core.trac.wordpress.org/ticket/49999.
@youknowriad
Copy link
Contributor

@youknowriad youknowriad commented Jun 29, 2020

Not sure it's really a blocker personally since other admin schemes don't change the color link either.
@jasmussen
Copy link
Contributor Author

@jasmussen jasmussen commented Jun 29, 2020

I would not think it a blocker, but it would be a nice follow-up.
@ryelle
Copy link
Contributor

@ryelle ryelle commented Jun 29, 2020

You can actually set the link color in a core scheme by setting $link & $link-focus, the _admin.scss base will set link colors using that variable.
@jasmussen
Copy link
Contributor Author

@jasmussen jasmussen commented Jun 29, 2020

I'm so happy I pinged you. Thanks, I'll get on that in both PRs!
@jasmussen
Copy link
Contributor Author

@jasmussen jasmussen commented Jun 30, 2020

This push, WordPress/wordpress-develop#369 (comment), makes the link color the same color as the highlight color. This should also bleed into the block editor so no need for work on this end.
@jasmussen jasmussen mentioned this pull request Jul 1, 2020
Closed
@youknowriad
youknowriad approved these changes Jul 2, 2020
View changes
Copy link
Contributor

@youknowriad youknowriad left a comment

This is already on trunk, so let's get this on Gutenberg too.
@jasmussen jasmussen merged commit c2d17df into master Jul 2, 2020
18 checks passed
18 checks passed
Check Check
Details
build
Details
Admin - 1
Details
pull-request-automation
Details
pull-request-automation
Details
test (gutenberg-editor-gallery)
Details
test (gutenberg-editor-gallery)
Details
All
Details
JavaScript
Details
Admin - 2
Details
PHP
Details
Admin - 3
Details
Mobile
Details
Admin - 4
Details
Author - 1
Details
Author - 2
Details
Author - 3
Details
Author - 4
Details
@jasmussen jasmussen deleted the add/modern-color-scheme branch Jul 2, 2020
@github-actions github-actions bot added this to the Gutenberg 8.5 milestone Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad

@ryelle ryelle

Assignees

@jasmussen jasmussen

Labels
[Type] Enhancement
Projects
None yet
Milestone
Gutenberg 8.5
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@jasmussen @earnjam @youknowriad @ryelle
You can’t perform that action at this time.