Skip to content

/ gutenberg

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify tooltip styles. #23382

Merged
merged 1 commit into from Jun 23, 2020
Merged

Unify tooltip styles. #23382

merged 1 commit into from Jun 23, 2020

Conversation

@jasmussen
Copy link
Contributor

@jasmussen jasmussen commented Jun 23, 2020

The tooltips were not all unified. This PR aims to do that.

Before:

Screenshot 2020-06-23 at 09 35 45

Screenshot 2020-06-23 at 09 37 46

Screenshot 2020-06-23 at 10 09 47

Here's the original design:

Screenshot 2020-06-23 at 10 09 24

After:

Screenshot 2020-06-23 at 10 09 47

Screenshot 2020-06-23 at 10 08 07

Screenshot 2020-06-23 at 10 10 01

This one presented me with some challenges:

Screenshot 2020-06-23 at 10 16 58

It's not a tooltip, but looking at these styles, this input field is styled in JS, which means it has its styles overwritten by wp-includes/forms.scss, and it's hard to increase specificity without using !important.
@jasmussen
Unify tooltip styles.
Loading status checks…
d0714ef
@jasmussen jasmussen self-assigned this Jun 23, 2020
@jasmussen jasmussen requested a review from mtias Jun 23, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Jun 23, 2020

Size Change: -82 B (0%)

Total Size: 1.13 MB

Filename Size Change
build/components/index.js 197 kB -103 B (0%)
build/components/style-rtl.css 15.8 kB +10 B (0%)
build/components/style.css 15.8 kB +11 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.62 kB 0 B
build/api-fetch/index.js 3.4 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 7.27 kB 0 B
build/block-directory/style-rtl.css 937 B 0 B
build/block-directory/style.css 937 B 0 B
build/block-editor/index.js 107 kB 0 B
build/block-editor/style-rtl.css 10.6 kB 0 B
build/block-editor/style.css 10.6 kB 0 B
build/block-library/editor-rtl.css 7.59 kB 0 B
build/block-library/editor.css 7.59 kB 0 B
build/block-library/index.js 129 kB 0 B
build/block-library/style-rtl.css 8.02 kB 0 B
build/block-library/style.css 8.02 kB 0 B
build/block-library/theme-rtl.css 730 B 0 B
build/block-library/theme.css 732 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.2 kB 0 B
build/compose/index.js 9.62 kB 0 B
build/core-data/index.js 11.4 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.44 kB 0 B
build/date/index.js 5.47 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 3.19 kB 0 B
build/edit-navigation/index.js 9.64 kB 0 B
build/edit-navigation/style-rtl.css 1.02 kB 0 B
build/edit-navigation/style.css 1.02 kB 0 B
build/edit-post/index.js 303 kB 0 B
build/edit-post/style-rtl.css 5.48 kB 0 B
build/edit-post/style.css 5.47 kB 0 B
build/edit-site/index.js 16.6 kB 0 B
build/edit-site/style-rtl.css 3.02 kB 0 B
build/edit-site/style.css 3.02 kB 0 B
build/edit-widgets/index.js 9.33 kB 0 B
build/edit-widgets/style-rtl.css 2.42 kB 0 B
build/edit-widgets/style.css 2.42 kB 0 B
build/editor/editor-styles-rtl.css 537 B 0 B
build/editor/editor-styles.css 539 B 0 B
build/editor/index.js 44.9 kB 0 B
build/editor/style-rtl.css 3.81 kB 0 B
build/editor/style.css 3.81 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.72 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.51 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.13 kB 0 B
build/list-reusable-blocks/style-rtl.css 450 B 0 B
build/list-reusable-blocks/style.css 451 B 0 B
build/media-utils/index.js 5.29 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 663 B 0 B
build/nux/style.css 660 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 14 kB 0 B
build/server-side-render/index.js 2.67 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action
@youknowriad youknowriad requested a review from ItsJonQ Jun 23, 2020
@mtias
mtias approved these changes Jun 23, 2020
View changes
@jasmussen jasmussen merged commit 4fe1c27 into master Jun 23, 2020
5 checks passed
5 checks passed
build build
Details
build
Details
pull-request-automation
Details
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@jasmussen jasmussen deleted the polish/resize-tooltips branch Jun 23, 2020
@github-actions github-actions bot added this to the Gutenberg 8.5 milestone Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtias mtias

@youknowriad youknowriad

@ajitbohra ajitbohra

@chrisvanpatten chrisvanpatten

@ItsJonQ ItsJonQ

Assignees

@jasmussen jasmussen

Labels
[Type] Code Quality [Type] Enhancement
Projects
None yet
Milestone
Gutenberg 8.5
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@jasmussen @mtias
You can’t perform that action at this time.