Add toggle control component to Storybook #18388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentswisher
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta,
talldan and
youknowriad
as code owners
gziolo
added
[Feature] UI Components
Good First Review
Storybook
Soean
reviewed
Nov 8, 2019
Soean
approved these changes
Nov 8, 2019
brentswisher
force-pushed
the
add/toggle-control-storybook
branch
from
1da7769
to
3162504
Compare
8 tasks
CreativeDive
pushed a commit
to CreativeDive/gutenberg
that referenced
this pull request
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
Adds the ToggleControl component to Storybook as part of #17973.
I added two stories, one with just the toggle control and one with variable help text based on the checked status.
How has this been tested?
run
npm run design-system:devBrowse to the local Storybook instance
See toggle control is rendered when selected in the left-hand navigation
Types of changes
New feature (non-breaking change which adds functionality)