Navigation Menu Item: fix showing input placeholder #18374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it fixes the visual issue which happens when the input is selected but not focused, showing the `Add Item...` placeholder.
retrofox
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
This was referenced Nov 7, 2019
obenland
approved these changes
Nov 7, 2019
| min-width: 20px; | ||
| } | ||
|
|
||
| .block-editor-rich-text__editable.is-selected:not(.keep-placeholder-on-focus):not(:focus) [data-rich-text-placeholder]::after { |
There was a problem hiding this comment.
What is this doing? I don't see any difference when I remove this rule. It sounds like something should be fixed for rich text instead of in the block.
There was a problem hiding this comment.
That seems to be correct, @ellatrix. The component has been developing constantly lately, and I think it's why these changes don't impact its behavior currently.
There was a problem hiding this comment.
Actually, @ellatrix, it seems that we've introduced a regression.
When the user tries to set the link text, it doesn't show the caret.
There was a problem hiding this comment.
Strange, I see it:
Is it caused by this PR?
There was a problem hiding this comment.
Yes. :-D
Fixed here: #20075
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It fixes the visual issue which happens when the input is selected but not focused not showing the
Add Item...placeholder.Fixes #18368
How has this been tested?
Add item...placeholder. For this, open the LinkControl popover, for instance.Screenshots
Types of changes
Checklist: