Show appender only when item has submenu #18153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
draganescu
reviewed
Oct 29, 2019
tellthemachines
added
the
Needs Design Feedback
|
Actually, now that #16708 has been merged, it makes more sense for the toolbar button to immediately insert a block. Will update. |
tellthemachines
force-pushed
the
add/submenu-toolbar-button
branch
from
80db5ba
to
6e626a3
Compare
shaunandrews
moved this from 👀 PRs to review
to 💻 Issues in progress
in Navigation editor
shaunandrews
moved this from 💻 Issues in progress
to 👀 PRs to review
in Navigation editor
draganescu
approved these changes
Oct 31, 2019
draganescu
force-pushed
the
add/submenu-toolbar-button
branch
from
557027c
to
4730cf8
Compare
CreativeDive
pushed a commit
to CreativeDive/gutenberg
that referenced
this pull request
Nov 12, 2019
* Show appender only when item has submenu * Address PR feedback. * Insert block directly from toolbar * updates submenu label, field css and shows toolbar button all the time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
Closes #18104.
Navigation menu items: Block appender should only be visible when the item already has a submenu.
If the item has no submenu, show a toolbar button that reveals the block appender on click.
Would love some a11y feedback on whether clicking the toolbar button should merely show/hide the appender, or if we should transfer focus to the appender, or announce its presence in any other way.
Currently clicking only shows/hides the appender so screen reader users won't get any feedback on what is happening.
How has this been tested?
Tested in browser:
Screenshots
Scenario 1:
Scenario 2:
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: