Skip to content

/ gutenberg

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Editor: Fix LinkControl text wrapping. #20448

Merged
merged 2 commits into from Feb 28, 2020
Merged

Block Editor: Fix LinkControl text wrapping. #20448

merged 2 commits into from Feb 28, 2020

Conversation

@epiqueras
Copy link
Contributor

@epiqueras epiqueras commented Feb 25, 2020

Fixes #20446
epiqueras added 2 commits Feb 25, 2020
@epiqueras
Block Editor: Remove unnecessary styles from LinkControl.
effdbec
@epiqueras
Block Editor: Fix LinkControl text wrapping.
7f79a2a
@epiqueras epiqueras added this to the Gutenberg 7.7 milestone Feb 25, 2020
@epiqueras epiqueras requested review from ellatrix and youknowriad as code owners Feb 25, 2020
@epiqueras epiqueras self-assigned this Feb 25, 2020
@epiqueras epiqueras mentioned this pull request Feb 25, 2020
Closed
@github-actions
Copy link

@github-actions github-actions bot commented Feb 25, 2020

Size Change: -1 B

Total Size: 864 kB

Filename Size Change
build/block-editor/style-rtl.css 10.3 kB -2 B (0%)
build/block-editor/style.css 10.3 kB +1 B
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1 kB 0 B
build/annotations/index.js 3.43 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.58 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.02 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-editor/index.js 104 kB 0 B
build/block-library/editor-rtl.css 7.67 kB 0 B
build/block-library/editor.css 7.67 kB 0 B
build/block-library/index.js 116 kB 0 B
build/block-library/style-rtl.css 7.49 kB 0 B
build/block-library/style.css 7.49 kB 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-default-parser/index.js 1.65 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 57.6 kB 0 B
build/components/index.js 190 kB 0 B
build/components/style-rtl.css 15.5 kB 0 B
build/components/style.css 15.5 kB 0 B
build/compose/index.js 5.76 kB 0 B
build/core-data/index.js 10.5 kB 0 B
build/data-controls/index.js 1.03 kB 0 B
build/data/index.js 8.22 kB 0 B
build/date/index.js 5.37 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.06 kB 0 B
build/edit-post/index.js 90.9 kB 0 B
build/edit-post/style-rtl.css 8.59 kB 0 B
build/edit-post/style.css 8.58 kB 0 B
build/edit-site/index.js 4.59 kB 0 B
build/edit-site/style-rtl.css 2.77 kB 0 B
build/edit-site/style.css 2.76 kB 0 B
build/edit-widgets/index.js 4.43 kB 0 B
build/edit-widgets/style-rtl.css 2.59 kB 0 B
build/edit-widgets/style.css 2.58 kB 0 B
build/editor/editor-styles-rtl.css 325 B 0 B
build/editor/editor-styles.css 327 B 0 B
build/editor/index.js 44.6 kB 0 B
build/editor/style-rtl.css 4.01 kB 0 B
build/editor/style.css 4 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.6 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 1.92 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.45 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.3 kB 0 B
build/keycodes/index.js 1.68 kB 0 B
build/list-reusable-blocks/index.js 2.99 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 4.85 kB 0 B
build/notices/index.js 1.57 kB 0 B
build/nux/index.js 3.02 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.54 kB 0 B
build/primitives/index.js 1.49 kB 0 B
build/priority-queue/index.js 879 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/rich-text/index.js 14.3 kB 0 B
build/server-side-render/index.js 2.54 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4 kB 0 B
build/viewport/index.js 1.61 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

@jorgefilipecosta
Copy link
Member

@jorgefilipecosta jorgefilipecosta commented Feb 28, 2020

Hi @epiqueras, I added the label Backport to WP Core as I think this PR needs to be backported. If that's not the base feel free to remove the label.

@jorgefilipecosta jorgefilipecosta added this to Needs Review in WordPress 5.4 Must Have Feb 28, 2020
@epiqueras
Copy link
Contributor Author

@epiqueras epiqueras commented Feb 28, 2020

Good call!

@aduth
aduth approved these changes Feb 28, 2020
View changes
@epiqueras epiqueras merged commit 64b0490 into master Feb 28, 2020
4 checks passed
4 checks passed
@github-actions
build
Details
@github-actions
pull-request-automation
Details
@github-actions
pull-request-automation
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
WordPress 5.4 Must Have automation moved this from Needs Review to Done Feb 28, 2020
@epiqueras epiqueras deleted the update/link-control-height-consistency branch Feb 28, 2020
jorgefilipecosta added a commit that referenced this pull request Mar 2, 2020
@epiqueras @jorgefilipecosta
Block Editor: Fix LinkControl text wrapping. (#20448)
6a87dbc
@jorgefilipecosta jorgefilipecosta mentioned this pull request Mar 2, 2020
Merged
jorgefilipecosta added a commit that referenced this pull request Mar 2, 2020
@epiqueras @jorgefilipecosta
Block Editor: Fix LinkControl text wrapping. (#20448)
6fd7289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduth aduth

@ellatrix ellatrix

@youknowriad youknowriad

Assignees

@epiqueras epiqueras

Labels
[Feature] Link Editing [Type] Bug
Projects
No open projects
Tightening Up
  
Awaiting triage
WordPress 5.4 Must Have
  
Done
Milestone
Gutenberg 7.7
Linked issues

Successfully merging this pull request may close these issues.

Block Editor: LinkControl suggestions height consistency, overflow
3 participants
@epiqueras @jorgefilipecosta @aduth