Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable webp format image #15068

Merged
merged 4 commits into from Jul 26, 2021
Merged

Enable webp format image #15068

merged 4 commits into from Jul 26, 2021

Conversation

@ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Jul 25, 2021

Fixes #2885

This PR enables webp format image display and upload in the WPAndroid app.

Related PRs

FluxC: wordpress-mobile/WordPress-FluxC-Android#2070
WordPress-Utils-Android: wordpress-mobile/WordPress-Utils-Android#89

To test

  1. Go to My Site -> Media
  2. Click + button to add an image from device
  3. Upload a webp format image
  4. Notice that the image is uploaded without issues
  5. Click the image from the media grid
  6. Notice that the image loads fine on the file details screen
webp_support.mp4

Merge Instructions

  • Targets 18.0, can be (preferably) merged with 17.9.

  • Only 1 reviewer is sufficient.

  1. Wait for the corresponding WordPress-Utils-Android and FluxC PRs to be merged to develop
  2. Create FluxC tag
  3. Replace WordPress-Utils-Android and FluxC tags in build.gradle
  4. Wait for release notes to be updated
  5. Remove Not Ready for Merge label
  6. Merge the PR

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
@ashiagr ashiagr added the Media label Jul 25, 2021
@peril-wordpress-mobile
Copy link

@peril-wordpress-mobile peril-wordpress-mobile bot commented Jul 25, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

@peril-wordpress-mobile peril-wordpress-mobile bot commented Jul 25, 2021

You can test the changes on this Pull Request by downloading the APKs:

@ashiagr ashiagr marked this pull request as ready for review Jul 26, 2021
@ashiagr ashiagr added this to the 18.0 milestone Jul 26, 2021
@ashiagr ashiagr removed this from the 18.0 milestone Jul 26, 2021
@ashiagr ashiagr added this to the 17.9 milestone Jul 26, 2021
@ashiagr ashiagr merged commit 8b97b12 into develop Jul 26, 2021
13 checks passed
13 checks passed
@peril-wordpress-mobile[bot]
Peril Found some issues. Don't worry, everything is fixable.
Details
@buildkite[bot]
buildkite/wordpress-android Build #718 passed (15 minutes, 21 seconds)
Details
@buildkite[bot]
buildkite/wordpress-android/checkstyle Passed (1 minute, 39 seconds)
Details
@buildkite[bot]
buildkite/wordpress-android/detekt Passed (1 minute, 46 seconds)
Details
@buildkite[bot]
buildkite/wordpress-android/ktlint Passed (2 minutes, 7 seconds)
Details
@buildkite[bot]
buildkite/wordpress-android/lint Passed (14 minutes, 11 seconds)
Details
@buildkite[bot]
buildkite/wordpress-android/pipeline-pipeline-upload Passed (3 seconds)
Details
@buildkite[bot]
buildkite/wordpress-android/test-imageeditor Passed (1 minute, 39 seconds)
Details
@buildkite[bot]
buildkite/wordpress-android/test-wordpress Passed (11 minutes, 55 seconds)
Details
@buildkite[bot]
buildkite/wordpress-android/test-wordpressprocessors Passed (1 minute, 19 seconds)
Details
ci/circleci: Installable Build Your tests passed on CircleCI!
Details
@peril-wordpress-mobile[bot]
ci/circleci: Optional Tests/Hold Your job is on hold on CircleCI!
Details
ci/circleci: submodules-strings-check Your tests passed on CircleCI!
Details
@ashiagr ashiagr deleted the issue/2885-add-webp-support-wpandroid branch Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants