Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-enable the template editor for themes with theme.json only #32858

Merged
merged 1 commit into from Jun 21, 2021

Conversation

@youknowriad
Copy link
Contributor

@youknowriad youknowriad commented Jun 21, 2021

Per feedback and discussions in the 5.8 leads channel, we're making the template editor opt-in for classic themes and opt-out for themes with theme.json and FSE themes.

To test this PR, you should have WP 5.7 or prior as, this flag is enabled in Core trunk and the effect of this PR won't be noticeable.

  • Test that by default classic themes have template editor disabled.
  • Test that if you add a "theme.json" file to a classic themes, the template editor is enabled.
@youknowriad youknowriad requested a review from desrosj Jun 21, 2021
@youknowriad youknowriad self-assigned this Jun 21, 2021
@youknowriad youknowriad requested review from aristath and WordPress/gutenberg-core Jun 21, 2021
@youknowriad youknowriad force-pushed the add/block-supports-theme-json branch from 19b8a58 to 769d68a Jun 21, 2021
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Looks good - thanks!

@youknowriad youknowriad merged commit 46df095 into trunk Jun 21, 2021
17 of 18 checks passed
17 of 18 checks passed
@github-actions
test (gutenberg-editor-initial-html, 14) test (gutenberg-editor-initial-html, 14)
Details
@github-actions
Bump version
Details
@github-actions
Checks (12)
Details
@github-actions
Admin - 1 Admin - 1
Details
@github-actions
Run performance tests
Details
@github-actions
pull-request-automation (14)
Details
@github-actions
test (12.2, gutenberg-editor-initial-html, 14)
Details
@github-actions
JavaScript (12)
Details
@github-actions
Checks (14)
Details
@github-actions
Admin - 2 Admin - 2
Details
@github-actions
JavaScript (14)
Details
@github-actions
Admin - 3 Admin - 3
Details
@github-actions
Admin - 4 Admin - 4
Details
@github-actions
Build Release Artifact
Details
@github-actions
Create Release Draft and Attach Asset
Details
@github-actions
Mobile
Details
@youknowriad youknowriad deleted the add/block-supports-theme-json branch Jun 21, 2021
@github-actions github-actions bot added this to the Gutenberg 11.0 milestone Jun 21, 2021
add_theme_support( 'block-templates' );

/**
* Enable the block templates (editor mode) for themes with theme.json.

This comment has been minimized.

@mtias

mtias Jun 22, 2021
Contributor

the first "the" could be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants