Opened 9 months ago
Closed 8 months ago
#52834 closed defect (bug) (fixed)
Reset password screen: improve buttons layout for better i18n
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.7.1 | Priority: | normal |
Severity: | normal | Version: | 5.7 |
Component: | Login and Registration | Keywords: | has-screenshots fixed-major has-patch commit dev-reviewed |
Focuses: | ui, css | Cc: |
Description ¶
Related: #39638
Props to @pixelverbieger for pointing this out.
In some locales, the two buttons position is not ideal. They should ideally be stacked when there is not enough place leave them float.
Commits (4)
- [50569] Login, Registration: Prevent button misalignment on password reset screen.… by @peterwilsoncc 8 months ago
- [50572] Login, Registration: Prevent button misalignment on password reset screen.… by @peterwilsoncc 8 months ago
- [50577] Login, Registration: Prevent button misalignment on login screen.… by @ryelle 8 months ago
- [50580] Login, Registration: Prevent button misalignment on login screen.… by @ryelle 8 months ago
Pull Requests
- Loading…
Change History (22)
#2
@ Core Committer
9 months ago
- Keywords commit added; 2nd-opinion removed
Tested across a few languages of different lengths, looks good across all.
#3
@
9 months ago
Thank you @audrasjb for reporting this. I just noticed the same issue.
I hope we can get this in in a minor version.
#4
@ Core Committer
9 months ago
- Milestone changed from Awaiting Review to 5.7.1
I think this would be good to put in the upcoming minor release.
#5
@ Core Committer
8 months ago
- Owner set to peterwilsoncc
- Resolution set to fixed
- Status changed from new to closed
In 50569:
#6
@ Core Committer
8 months ago
- Keywords fixed-major dev-feedback added
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening for commit to the 5.7 branch following second a committer's sign-off.
#7
@ Core Committer
8 months ago
- Keywords dev-reviewed added; dev-feedback removed
Based on my earlier review this is good to backport.
#8
@ Core Committer
8 months ago
- Resolution set to fixed
- Status changed from reopened to closed
In 50572:
#9
@
8 months ago
- Resolution fixed deleted
- Status changed from closed to reopened
Login page button issue after removed the below CSS in #50572
.login .button-primary { float: right; }
I'm using a development version (5.8-alpha-50571).
#10
@ Core Committer
8 months ago
- Keywords needs-patch added; has-patch commit removed
I can reproduce the issue as well, thanks @mukesh27
#13
@ Core Committer
8 months ago
The above patch restore the previous rule and keep the new one used in password reset form.
#14
@ Core Committer
8 months ago
- Resolution set to fixed
- Status changed from reopened to closed
In 50577:
#15
@ Core Committer
8 months ago
- Keywords commit dev-feedback added
- Resolution fixed deleted
- Status changed from closed to reopened
Thanks for catching that @mukesh27!
Reopening for backport.
German translation i18n issue