Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jest #67

Closed
wants to merge 1 commit into from
Closed

Remove jest #67

wants to merge 1 commit into from

Conversation

roythearsonist
Copy link
Contributor

Motivation

I saw that jest was listed as a dependency but it wasn't used anywhere.

Changes

I removed it from the list

Additional Comments

Sorry I didn't generate the yarn.lock, it wasn't working on my machine.

@vercel
Copy link

vercel bot commented Sep 26, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @kimlimjustin on Vercel.

@kimlimjustin first needs to authorize it.

@kimlimjustin
Copy link
Owner

Erm, firstly thanks for your interest to contribute to Xplorer, however, jest is actually being used on the project, it is under the test directory, I know that it might weird because it doesn't import the module there, this is because of the design made by the jest.

Xplorer need jest to run the test cases under the test folder, you can run the test case by running the yarn test / npm run test command, this command will call the jest to run the test cases. (

"test": "jest",
)

Also, the test is run on the GitHub CI workflows everytime there's commit to master branch.

I'm really sorry that I should close this PR, really thanks for your interest to contributr tho

@roythearsonist roythearsonist deleted the remove-jest branch September 26, 2021 23:34
@roythearsonist
Copy link
Contributor Author

I was just about to come and close it now that I realized that. Sorry for wasting your time.

@kimlimjustin
Copy link
Owner

Hahaha, it's okay, thank you tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants