Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the pot file use the same license as the plugin #199

Merged
merged 3 commits into from Dec 13, 2019

Conversation

@ponsfrilus
Copy link
Contributor

@ponsfrilus ponsfrilus commented Dec 12, 2019

It's green :)
image
image

This PR now includes a test case that ensure that the licensing information in the pot file is taken from the plugin file header if exists. Fixes #198.

ponsfrilus added 3 commits Dec 11, 2019
The doc says: 
```
If a plugin or theme specifies a license in their main plugin file or stylesheet, the comment looks like
this: 
Copyright (C) 2018 Example Plugin Author
This file is distributed under the GPLv2.
```
but it dosen't seems to work for plugins. It looks like the "License" param in get_file_headers was missing.
* Only if the license file header is defined
* Tests updated
@ponsfrilus ponsfrilus requested a review from wp-cli/committers as a code owner Dec 12, 2019
@schlessera schlessera merged commit 2804c52 into wp-cli:master Dec 13, 2019
2 checks passed
2 checks passed
@dep
DEP All dependencies are resolved
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schlessera schlessera added this to the 2.2.2 milestone Dec 13, 2019
@schlessera
Copy link
Member

@schlessera schlessera commented Dec 13, 2019

Thanks for the PR, @ponsfrilus !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants