Ensure that the pot file use the same license as the plugin #199
Conversation
The doc says: ``` If a plugin or theme specifies a license in their main plugin file or stylesheet, the comment looks like this: Copyright (C) 2018 Example Plugin Author This file is distributed under the GPLv2. ``` but it dosen't seems to work for plugins. It looks like the "License" param in get_file_headers was missing.
* Only if the license file header is defined * Tests updated
Thanks for the PR, @ponsfrilus ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
It's green :)
![image](https://webcf.waybackmachine.org/web/20210830083434im_/https://user-images.githubusercontent.com/176002/70705976-50f3fb00-1cd5-11ea-888a-3e98de9d24fc.png)
![image](https://webcf.waybackmachine.org/web/20210830083434im_/https://user-images.githubusercontent.com/176002/70706261-de374f80-1cd5-11ea-9bcf-67cb31ffc34b.png)
This PR now includes a test case that ensure that the licensing information in the pot file is taken from the plugin file header if exists. Fixes #198.