Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Quality] Use DAG factory for all provider API scripts #1713

Closed
1 task done
obulat opened this issue Sep 3, 2021 · 0 comments · Fixed by WordPress/openverse-catalog#163
Closed
1 task done

[Quality] Use DAG factory for all provider API scripts #1713

obulat opened this issue Sep 3, 2021 · 0 comments · Fixed by WordPress/openverse-catalog#163
Labels
💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users
Projects
Openverse

Comments

@obulat
Copy link
Contributor

obulat commented Sep 3, 2021

Current Situation

We have a dag_factory function that creates DAGs for retrieving data from provider APIs. Some workflows use it, and some don't.

Suggested Improvement

All provider API workflows should use the dag_factory.

Benefit

The consistency will make code maintenance easier.

Additional context

Thank you @krysal for bringing the dag_factory to my attention during one of the PR reviews :)

Implementation

  • 🙋 I would be interested in implementing this feature.
@obulat obulat added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Sep 3, 2021
@obulat obulat mentioned this issue Sep 3, 2021
Merged
7 tasks
@zackkrida zackkrida added 💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Sep 14, 2021
@obulat obulat transferred this issue from WordPress/openverse-catalog Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users
Projects
Openverse Backlog
Archived in project
Openverse
  
Done!
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use dag_factory for Provider API DAG creation WordPress/openverse-catalog
2 participants
@zackkrida @obulat