Media library upload freezes on multiple uploads from gallery

[glendaviesnz]

Related to ​https://github.com/WordPress/gutenberg/issues/11373, and possibly #50210

If adding a Gallery via Gutenberg, if a file is dropped onto the core media library the first upload succeeds as expected. If a second Gallery is added and another image dropped on the core media library this uploaded freezes and an uncaught exception Uncaught TypeError: Cannot read property 'text' of undefined in the `wp_includes/js/media-views.js file.

To replicate:

1. Go to Posts > Add new.
2. Add a title.
3. Add a Gallery block.
4. Click on Media Library inside the Gallery Block, add two photos.
5. Enter the gallery on to the page. The photos appear. All is fine.
6. Add another Gallery block.
7. Click on Media Library in the Gallery Block again,
8. Drag a photo onto the Media library to upload it.
9. The upload bar shows 15%-ish done, but then just hangs. Nothing is shown on the far right side. If I click on the photo upload, I get the name of the image, so the Media library is only partially not working.
10. Using the x on the upper right to close the Media library and opening it again, just brings up the same frozen upload.
11. Drag another photo into the Media Library, upload also hangs.

Trac ticket: https://core.trac.wordpress.org/ticket/53169

Related to ​https://github.com/WordPress/gutenberg/issues/11373, and possibly https://core.trac.wordpress.org/ticket/50210
If adding a Gallery via Gutenberg, if a file is dropped onto the core media library the first upload succeeds as expected. If a second Gallery is added and another image dropped on the core media library this uploaded freezes and an uncaught exception Uncaught TypeError: Cannot read property 'text' of undefined in the `wp_includes/js/media-views.js file.
To replicate:

1. Go to Posts > Add new.
2. Add a title.
3. Add a Gallery block.
4. Click on Media Library inside the Gallery Block, add two photos.
5. Enter the gallery on to the page. The photos appear. All is fine.
6. Add another Gallery block.
7. Click on Media Library in the Gallery Block again,
8. Drag a photo onto the Media library to upload it.
9. The upload bar shows 15%-ish done, but then just hangs. Nothing is shown on the far right side. If I click on the photo upload, I get the name of the image, so the Media library is only partially not working.
10. Using the x on the upper right to close the Media library and opening it again, just brings up the same frozen upload.
11. Drag another photo into the Media Library, upload also hangs.

[prbot]

​glendaviesnz commented on ​PR #1235:

I don't know this part of the code well at all, and couldn't work out why theses values were undefined in some instances, so may be better to trace it further back and prevent this method being hit at all if these values are not defined.

[Mista-Flo]

Hi there,

Thanks for the great explanation and the patch!

I can reproduce the bug.

After applying the patch, it fixes the issue, and I don't have the error on the console anymore. I can successfully publish a post and view it on the frontend (on trunk, last version of Gutenberg plugin enabled, twentytwenty theme enabled).

Good job 👏 👍

[hellofromTonya]

As @Mista-Flo tested it, marking for commit.

[antpb]

In [51123]

Media: Allow multi-uploads in Galleries.
Previously, when more than one media item was uploaded using a gallery, failures occurred on the second upload.
Props glendaviesnz, Mista-Flo, hellofromTonya.
Fixes #53169.