Require PHPUnit 8/9 + PHP 7.2 for Unit tests w/ code modification shim for PHP 5.6-7.1 #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…moved once tests are migrated to newer function names.
… change to avoid updating every testcase in the PR. Add a compat method for assertStringContainsString()
…l with proper $this scope
…method by underscoring it
dd32
force-pushed
the
add/switch-to-phpunit8-9
branch
from
0b48687
to
8289ad5
Compare
dd32
force-pushed
the
add/switch-to-phpunit8-9
branch
2 times, most recently
from
4e889e5
to
c1222e7
Compare
…ere it belongs) and add the rest of the related methods.
dd32
force-pushed
the
add/switch-to-phpunit8-9
branch
from
c1222e7
to
a497885
Compare
…to their non-namespace variants.
|
This is no longer needed, as the work has been done by others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/46149
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.