THEME: Variant Landing Page Four – 1.0.2

[InkThemes.com]

Variant Landing Page Four - 1.0

Variant Landing Page Four is a Landing Page WordPress Theme that’s perfect for creating a landing page website. Variant Landing Page Four is completely responsive and gives a nice look to your website.

Theme URL - ​http://www.inkthemes.com/variant-landing-page-four-wordpress-theme/
Author URL - ​http://www.inkthemes.com/

SVN - ​https://themes.svn.wordpress.org/variant-landing-page-four/1.0
ZIP - ​https://wordpress.org/themes/download/variant-landing-page-four.1.0.zip?nostats=1

History:

Ticket	Summary	Status	Resolution	Owner
#29258	THEME: Variant Landing Page Four – 1.0.2	closed	not-approved	joedolson
(this ticket)
#32827	THEME: Variant Landing Page Four – 1.0.5	closed	live	joedolson
#42428	THEME: Variant Landing Page Four – 1.0.6	closed	live	themetracbot
#50023	THEME: Variant Landing Page Four – 1.0.7	closed	live	themetracbot

[mikeselander]

Hi InkThemes, I just finished reviewing your theme and I have some notes for you. The theme is not approved as of yet, but all of the failure points are really easy to fix and will take very little work to get to a passable stage.

Once you fix these items, we will re-review and and go from there. Feel free to let me know any questions and comments!

Required Items:

1. Not escaping all outputs into the theme from theme mods (i.e.: background image, phone number, header info, etc.)
2. Translation - The following need to be translation-ready:
   1. “Submit Comment” in comments.php
   2. All examples of Strings in comments_popup_link
   3. “Permanent Link to” in content.php
   4. “Variant All rights reserved” in footer.php (also, no need to esc_html here)
   5. “Post Image” in functions.php
   6. “FormGet Contact Form”, “Formget Placeholder” in variantly-functions.php
   7. Defaults in variant-customizer.php (missing some)
   8. Footer “Variant All rights reserved” in landing-page.php
3. Use locate_template() instead of include_once for loading the landing page template file

Recommended Items:

1. Add editor style is empty in functions.php, not pulling in a file - recommend eliminating the call
2. Not using custom sizes for the Featured Items or log, leading to images getting scrunched and loading an image way too big. Since users will inevitable load in a poorly-sized or too-large photo, use a custom crop for better performance and consistency.
3. You have testimonials & footer text sections prepared in variant-customizer.php, but not using them in the Customizer panel or theme. Please remove if not using.
   1. The footer text would be a nice feature for users, I recommend re-including it.
4. Documentation could be far improved on custom functionality - I won’t make this a requirement to pass, but I would recommend spending more time on it in the future.
5. 880 × 660 is OK for the screenshot, but recommend 1200 x 900 for full-Retina screens
6. Recommend tel: linking the phone # in the header

Personal Notes:

1. TGMPA still has example documentation
2. Enqueuing stylesheets in 2 places, should combine to one
3. Spelling error in readme.txt “Begining” —> Beginning
   1. You also have several grammatical errors in this file. It’s a small thing, but might be important to you.

[mikeselander]

scrunched image

[emiluzelac]

Accidentally closed.

[InkThemes.com]

No problem.

@mikeselander Thank you for giving your valuable time to review this theme.

I will fix the issues and re upload theme soon.

Best Regards
Krish

[themetracbot]

Variant Landing Page Four - 1.0.1

Variant Landing Page Four is a Landing Page WordPress Theme that’s perfect for creating a landing page website. Variant Landing Page Four is completely responsive and gives a nice look to your website.

Theme URL - ​http://www.inkthemes.com/variant-landing-page-four-wordpress-theme/
Author URL - ​http://www.inkthemes.com/

SVN - ​https://themes.svn.wordpress.org/variant-landing-page-four/1.0.1
ZIP - ​https://wordpress.org/themes/download/variant-landing-page-four.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=variant-landing-page-four/1.0&new_path=variant-landing-page-four/1.0.1

History:

Ticket	Summary	Status	Resolution	Owner
#29258	THEME: Variant Landing Page Four – 1.0.2	closed	not-approved	joedolson
(this ticket)
#32827	THEME: Variant Landing Page Four – 1.0.5	closed	live	joedolson
#42428	THEME: Variant Landing Page Four – 1.0.6	closed	live	themetracbot
#50023	THEME: Variant Landing Page Four – 1.0.7	closed	live	themetracbot

[InkThemes.com]

Hello @mikeselander,

Fixed all the issues and uploaded the theme with latest version.

Thanks & Regards
InkThemes

[mikeselander]

Hi Krish (cc: @InkThemes.com), I just wanted to let you know that I've seen your update and will review it as soon as I can. This weekend is a bit crazy for me as I'm speaking at WC London but I'm hoping to get you finished up tomorrow, and if not then on Sunday :)

[InkThemes.com]

@mikeselander,

That's great :).

No problem, finish up your speech first.

Best Regards
Krish

[mikeselander]

Hi @InkThemes.com, thank you for your patience! I only have one more note + one more recommendation and then we can get it off to an admin for a final review.

Requirement:

1. The phone number color is too light against the white background - the contrast needs to be higher for accessibility and therefore the color on that needs to be darker.

Strongly Recommend

1. I really recommend using cropped image sizes for the featured circles. It won't take much time to implement and will vastly improve the performance of any sites that this ends up on and the trust that your users have in the theme.

Once the required item (and hopefully the recommended) is completed I will approve and send on to the admin review.

Thanks!

[themetracbot]

Variant Landing Page Four - 1.0.2

Variant Landing Page Four is a Landing Page WordPress Theme that’s perfect for creating a landing page website. Variant Landing Page Four is completely responsive and gives a nice look to your website.

Theme URL - ​http://www.inkthemes.com/variant-landing-page-four-wordpress-theme/
Author URL - ​http://www.inkthemes.com/

SVN - ​https://themes.svn.wordpress.org/variant-landing-page-four/1.0.2
ZIP - ​https://wordpress.org/themes/download/variant-landing-page-four.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=variant-landing-page-four/1.0.1&new_path=variant-landing-page-four/1.0.2

History:

Ticket	Summary	Status	Resolution	Owner
#29258	THEME: Variant Landing Page Four – 1.0.2	closed	not-approved	joedolson
(this ticket)
#32827	THEME: Variant Landing Page Four – 1.0.5	closed	live	joedolson
#42428	THEME: Variant Landing Page Four – 1.0.6	closed	live	themetracbot
#50023	THEME: Variant Landing Page Four – 1.0.7	closed	live	themetracbot

[InkThemes.com]

Hello @mikeselander,

Fixed the above issues and uploaded the theme with new version.

Thanks
InkThemes

[mikeselander]

Hi @InkThemes.com - looks great. I'm going to approve this and kick it into the admin review queue. If everything looks good on their end they'll push you live once they have a chance to review.

Thanks!

[WPDevHQ]

Theme should not have been approved due to the following issues!

Required:

• When user's settings is for front page to show post this theme does not honor that setting due incorrect frontpage.php configuration.

• Theme should not use wp_reset_query(); and should use wp_reset_postdata(); instead - tpl-blog.php.

• Footer copyright should reflect the site the theme is installed on and not the theme itself.

• $content_width should be inside a function callback hooked to the after_setup_theme action.

• Should't be using both html5 for search-form as well as a searchform.php

• The dynamic-image.php script is plugin territory.

[InkThemes.com]

Hello @WPDevHQ,

Thanks for reviewing,

We will fix all raised issues and update the theme soon.

[InkThemes.com]

Hello @WPDevHQ,

In your last point: I used image resizer function/script for cropping the images that showing in the home template. Because in earlier @mikeselander's review had recommended to crop the image:

I really recommend using cropped image sizes for the featured circles. 
It won't take much time to implement and will vastly improve the performance of any sites that this ends up on and the trust that your users have in the theme.

Now you said the script is plugin territory, so please could you suggest what should I do?

[WPDevHQ]

WordPress already has the functionality built in like you already applied @line 56 in functions.php with add_image_size('variantlp_post_thumbnail', 672, 253, true);.

If you are calling post thumbnails/featured images of various sizes in different place you can use the same method.

The reviewer may have need to regenerate the thumbnails if he didn't do so before making the suggestion. But in no way did he suggest to use a separate script that falls under plugin territory.

[mikeselander]

@InkThemes.com as @WPDevHQ said, I was recommending making use of the inbuilt cropping functionality that comes with defining a custom image size and calling that size on the front end.

Sorry for the lack of clarity!

[joedolson]

I'm reopening this review for the accessibility-ready audit, which is required for themes with the accessibility-ready tag. I'll get this done as soon as possible!