Widget preivew not working if widget registered via a instance #32781
Conversation
53 tasks
noisysocks
approved these changes
Jun 21, 2021
Tested that previewing a Legacy Widget works when running plugin against trunk and 5.7. LGTM
spacedmonkey
reviewed
Jun 21, 2021
spacedmonkey
reviewed
Jun 21, 2021
spacedmonkey
reviewed
Jun 21, 2021
|
The failure looks unrelated, I just restarted the job. |
noisysocks
merged commit ef339e3
into
WordPress:trunk
17 checks passed
17 checks passed
![@github-actions[bot]](https://webcf.waybackmachine.org/web/20210916094420im_/https://avatars.githubusercontent.com/in/15368?v=4){kind=small}
noisysocks
added a commit
that referenced
this issue
Jun 22, 2021
jorgefilipecosta
added a commit
that referenced
this issue
Jun 22, 2021
vcanales
added a commit
that referenced
this issue
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Description
Details on this ticket can be found here - https://core.trac.wordpress.org/ticket/53427
This ticket introduces a new filter called
wp_get_legacy_widget_keywhich means that we do not have hardcode references togutenberg_get_widget_objectinto core.How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).The text was updated successfully, but these errors were encountered: