Fix text-menu min widths. #34532
Merged
Fix text-menu min widths. #34532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
the
[Type] Regression
jasmussen
requested review from
ajitbohra,
chrisvanpatten and
ellatrix
as code owners
|
CC: @aaronrobertshaw @andrewserong, this PR might fix the tools menu min width in a more generic way. |
|
Size Change: -2.62 kB (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
7 tasks
ciampo
moved this from In progress (owned) ⏳
to In progress ⏳ (un-owned)
in WordPress Components
jasmussen
commented
Sep 3, 2021
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| ### Breaking Change | |||
|
|
|||
| - Removed a min-width from the `DropdownMenu` component, allowing the menu to accommodate thin contents like vertical tools menus ([#33995](https://github.com/WordPress/gutenberg/pull/33995)). | |||
There was a problem hiding this comment.
Let me know if this sounds good.
There was a problem hiding this comment.
Sounds good, I was initially confused since this PR adds two min-widths and not removing, but docs are for previous PR 👍
mkaz
approved these changes
Sep 3, 2021
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| ### Breaking Change | |||
|
|
|||
| - Removed a min-width from the `DropdownMenu` component, allowing the menu to accommodate thin contents like vertical tools menus ([#33995](https://github.com/WordPress/gutenberg/pull/33995)). | |||
There was a problem hiding this comment.
Sounds good, I was initially confused since this PR adds two min-widths and not removing, but docs are for previous PR 👍
WordPress Components
automation
moved this from In progress ⏳ (un-owned)
to In progress (owned) ⏳
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #34518. #33995 removed a min-width on popovers, causing some menus to be small.
This PR fixes the two issues found.
How has this been tested?
Please test the Image block URL dropdown.
Please dropdown menus that feature the "menu item" component, including the "add existing" dropdown on the navigation block.
Before:
After:
Checklist:
*.native.jsfiles for terms that need renaming or removal).