Remove the ENVIRONMENT_DIRECTORY env variable that was added to the performance jobs #34086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.03 MB ℹ️ View Unchanged
|
kevin940726
approved these changes
Aug 16, 2021
|
@kevin940726 What's the issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This variable has been added recently in #33414 but it makes running the performance tests locally harder. (need to provide the variable).
Testing instructions
Run
npm run test-performance packages/e2e-tests/specs/performance/post-editor.test.jslocally ornpm run test-performance. It should work without errors.