Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added janw-me to the Codeowners for the PHP FSE folder. #32990

Merged
merged 7 commits into from Aug 26, 2021

Conversation

@janw-me
Copy link
Contributor

@janw-me janw-me commented Jun 25, 2021

I'd like to get the updates for this folders.
I apologize if this is the wrong approach.

Copy link
Contributor

@priethor priethor left a comment

Hi @janw-me !

This would be one way of getting notifications, although you would also get added as a reviewer on every PR that affects files in that folder.

As an alternative, if you are only interested in getting notifications once changes to that folder happen in trunk, there's also the possibility of setting up an RSS feed with the following URL:
https://github.com/WordPress/gutenberg/commits/trunk/lib/full-site-editing.atom

However, in case you do want to be added to the code owners, I left a review to address the changes.

.github/CODEOWNERS Outdated Show resolved Hide resolved
@janw-me
Copy link
Contributor Author

@janw-me janw-me commented Aug 26, 2021

Hi @priethor

Thank you for the atom feed. That's quite usefull.
But if it's allowed I'd like to be pinged before it's merged.

@priethor priethor merged commit c3d2b8b into WordPress:trunk Aug 26, 2021
18 checks passed
18 checks passed
@github-actions
Compute current and next stable release branches
Details
@github-actions
Checks (12)
Details
@github-actions
Admin - 1 Admin - 1
Details
@github-actions
Run performance tests
Details
@github-actions
test (gutenberg-editor-initial-html, 14)
Details
@github-actions
test (12.2, gutenberg-editor-initial-html, 14)
Details
@github-actions
JavaScript (12)
Details
@github-actions
Checks (14)
Details
@github-actions
Admin - 2 Admin - 2
Details
@github-actions
JavaScript (14)
Details
@github-actions
Admin - 3 Admin - 3
Details
@github-actions
Admin - 4 Admin - 4
Details
@github-actions
Bump version
Details
@github-actions
Build Release Artifact
Details
@github-actions
Mobile
Details
@github-actions
Create Release Draft and Attach Asset
Details
@github-actions github-actions bot added this to the Gutenberg 11.5 milestone Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants