Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table block: Merge/Unmerge cells #15821

Open
Tracked in #32400
mapk opened this issue May 24, 2019 · 24 comments · May be fixed by #17261
Open
Tracked in #32400

Table block: Merge/Unmerge cells #15821

mapk opened this issue May 24, 2019 · 24 comments · May be fixed by #17261
Assignees
Labels
Projects

Comments

@mapk
Copy link
Contributor

mapk commented May 24, 2019

The Table block does not provide a way to merge or unmerge cells. It's a popular feature request for the Table block, let's see if we can make this happen. 😉

Something similar to this (Google Docs):

merge

We can expose this action in the dropdown similarly to how we display the other actions.

merge-cells

@mapk mapk added [Block] Table Needs Design Feedback labels May 24, 2019
@mapk mapk added this to Backlog in Phase 2 via automation May 24, 2019
@mapk
Copy link
Contributor Author

mapk commented May 24, 2019

This request was noted here: #6923 by @helen.

@talldan
Copy link
Contributor

talldan commented May 27, 2019

Thanks so much for helping define these tasks @mapk! Would definitely be great to get this in.

Some tangible steps could be taken towards cell merging:

  • Support the colspan attribute on the underlying HTML (would at least allow merged cells for pasted tables, or those edited in the HTML editor. This is the basic foundation needed for the cell merging feature to work)
  • Cell navigation and selection needs to be improved (keyboard navigation, multiple cell selection). I started working on keyboard nav, so will hopefully have a PR incoming for that, but haven't had that much time lately to work on things.

@charlyox
Copy link

charlyox commented Jul 8, 2019

Hello here, this feature is really missing indeed, especially in a B2B context ! I can't wait for it. I'm a php / JS dev, I'd be happy to help !
Thanks a lot

@noisysocks noisysocks moved this from Backlog to Tighten Up in Phase 2 Jul 10, 2019
@noisysocks noisysocks added the [Type] Enhancement label Jul 10, 2019
@noisysocks noisysocks added this to To do in Table block via automation Jul 19, 2019
@noisysocks noisysocks removed this from Tighten Up in Phase 2 Jul 19, 2019
@charlyox
Copy link

charlyox commented Jul 19, 2019

Would it be a good start to allow html editing with colspan & rowspan attributes ?

@talldan talldan moved this from To Do to In Progress in Table block Sep 4, 2019
@adamsilverstein adamsilverstein linked a pull request Sep 4, 2019 that will close this issue
13 tasks
@gziolo
Copy link
Member

gziolo commented Nov 20, 2019

The same feature was requested on the Gutenberg plugin forum:
https://wordpress.org/support/topic/table-block-no-cell-merging/

@dmvvilela
Copy link

dmvvilela commented Jan 31, 2020

So nothing yet?

@jobthomas
Copy link
Contributor

jobthomas commented Mar 5, 2020

Confirming that this would be a great addition to the table block.

@adamsilverstein
Copy link
Member

adamsilverstein commented Mar 5, 2020

Thanks for the reminders, I'll try to pick up work on #17261 or parallel efforts soon.

@mapk mapk added Needs Dev and removed Needs Design Feedback labels Mar 6, 2020
@alexrhino
Copy link

alexrhino commented Mar 12, 2020

we would definitely need this feature too

@afercia
Copy link
Contributor

afercia commented May 8, 2020

Reported also on core Trac, see https://core.trac.wordpress.org/ticket/50071

@ocean90
Copy link
Member

ocean90 commented May 20, 2020

@adamsilverstein Is there something we can help you with? Are there any blockers?

@sergeiermilov
Copy link

sergeiermilov commented Aug 18, 2020

How can I find out the status of this issue?

@tnchuntic
Copy link

tnchuntic commented Aug 19, 2020

Is it possible to add list block inside table? like innerblock or something.

@pokhiii
Copy link

pokhiii commented Sep 19, 2020

This is such a common use case that it's frustrating that it's not already there. I tried to add rowspan by converting to HTML but it makes the table block invalid.

Guten Team, please look into this 🙏

@klostrophobik
Copy link

klostrophobik commented Nov 16, 2020

Mark me down as another request. I've got a few hundred staff members that are using your tables on our site and would like to be able to do this.

@sergeiermilov
Copy link

sergeiermilov commented Nov 17, 2020

Gutenberg team, are you listening anybody?!

@jeffpaul
Copy link
Member

jeffpaul commented Nov 17, 2020

@sergeiermilov yes, the team is listening and there's a work-in-progress PR for this so if this is something or urgent and/or important need for you then please see how you can help on that PR.

@joelyoder
Copy link

joelyoder commented Mar 1, 2021

  • Support the colspan attribute on the underlying HTML (would at least allow merged cells for pasted tables, or those edited in the HTML editor. This is the basic foundation needed for the cell merging feature to work)

Is there any downside to including colspan support like @talldan mentions above? Assuming it doesn't break the editor, it would be a good stopgap for now. I'm ok with having to add in the colspan manually, but not having any support for it becomes frustrating when converting a lot of pages that used that feature.

@sabernhardt
Copy link
Contributor

sabernhardt commented Mar 31, 2021

Trac #52937: another request for simply allowing these attributes in the table block (when using edit as HTML)

@jdaviescoates
Copy link

jdaviescoates commented Aug 10, 2021

I just wanted to do this and so came here and found this issue. Seems there has been a work-in-progress PR since 2019! Any chance of us getting this anytime soon? Thanks!

@jeffpaul
Copy link
Member

jeffpaul commented Aug 10, 2021

@jdaviescoates checking in on #18768 is probably best as that's where folks are confirming approach, which will then either need to be updated in #17261 or crafted via a new PR.

@WhiteX
Copy link

WhiteX commented Jan 8, 2022

While we wait... what's the best workaround you found? I'm looking for bringing some tables from MS Word to WP, and the lack of the merged cells feature makes it impossible to handle with the default options.

@joelyoder
Copy link

joelyoder commented Jan 8, 2022

While we wait... what's the best workaround you found? I'm looking for bringing some tables from MS Word to WP, and the lack of the merged cells feature makes it impossible to handle with the default options.

The simplest solution I've found in the meantime is just using a table inside of a Classic Block. Anything you could do in TinyMCE before will work in that block.

@WhiteX
Copy link

WhiteX commented Jan 8, 2022

Thanks @joelyoder , I tried and it might be a good substitute for a while :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Table block
  
In Progress
Development

Successfully merging a pull request may close this issue.