Skip to:
Content

bbPress.org

Opened 8 years ago

Closed 8 years ago

#2295 closed defect (fixed)

Topic split not updating menu order

Reported by: lakrisgubben Owned by: johnjamesjacoby
Milestone: 2.4 Priority: normal
Severity: normal Version: trunk
Component: Component - Topics Keywords:
Cc:

Description

After splitting up a topic, the menu order for all "new" posts (the new topic and its replies) aren't updated which results in bbp_get_reply_url() returning wrong url (with /page/n/) if the topic that was split was split after its first page.

​http://bbpress.trac.wordpress.org/browser/trunk/includes/topics/functions.php#L1605 Should be changed to "menu_order" instead of "post_position".

And also wouldn't it be good if the new topic got menu_order 1? If so, just add "menu_order => 1," on line ​http://bbpress.trac.wordpress.org/browser/trunk/includes/topics/functions.php#L1471

Change History (2)

#1 @johnjamesjacoby
8 years ago

  • Milestone changed from Awaiting Review to 2.4

Hm. That's annoying. Moving to 2.4 to look into this then.

#2 @johnjamesjacoby
8 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 5036:

When splitting a topic, correctly update the 'menu_order' property of the new topic post.

  • Replace instances of 'post_position' with 'menu_order'
  • Make sure 'menu_order' is 0

Props lakrisgubben. Fixes #2295.

Note: See TracTickets for help on using tickets.