Infrastructure for Cross-Locale PTEs

[akirk]

As ​discussed on September 7th in Slack, there are some changes necessary to allow cross-locale PTEs on translate.wordpress.org (see ​Cross-Locale PTE Trial for more background).

It was agreed that

• Specific user accounts (cross-locale PTEs) are able to import and approve translations for specific projects for all locales.
• A cross-locale PTE can import (or translate through UI) untranslated strings as current.
• A cross-locale PTE can import (or translate through UI) translated (by the community) strings as waiting.
• Translations by a cross-locale PTE can be overwritten by a regular PTE or a GTE.

This will need:

• An interface (admin.php?page=add-cross-locale-pte) to assign the GlotPress permission which needs:
  • an input field for username/email
  • The project list/table as it already exists in the PTE assigning interface
  • A submit button
• Filters in GlotPress to allow this (PR on ​GlotPress-WP to follow).
• Code in wporg-gp-rosetta-roles to enforce the permissions listed above.

[ocean90]

#1765 was marked as a duplicate.

[akirk]

The GlotPress side of this is tracked in ​https://github.com/GlotPress/GlotPress-WP/issues/537 which already has a ​pull request along with a ​sample implementation of a WordPress-GlotPress plugin (to be converted into a Rosetta plugin).

[akirk]

I have now added a first version of both admin interface and GlotPress plugin. The patch also extends the current GlotPress hook which is used in translate.wordpress.org. Happy to hear any reviewing thoughts!

[ocean90]

@akirk I couldn't get 2000.2.diff​ working.

2000.3.diff​ includes a few fixes:

• Adds a require_once for the Cross_Locale_PTE class (global.w.org mu-plugins are not loaded for translate.w.org)
• Fixes first argument of Cross_Locale_PTE::user_has_cross_locale_permission(), it's a user object, not only a user ID
• Adds the date_added field in Cross_Locale_PTE::update_cross_locale_pte()
• Fixes the user property in Cross_Locale_PTE::get_all_users() for the email, email => user_email

It looks like the current code doesn't handle our project hierarchy. For example I added the user to plugin X, but the translations are actually in a sub-project (dev/stable/dev-readme/stable-readme) of X. See #2255 for some background around this.

[ocean90]

In 4510:

Translate, Rosetta Roles: Add support for the new translation object type.

See ​https://github.com/GlotPress/GlotPress-WP/pull/538.
See #2000.

[akirk]

@ocean90 Thanks for your fixes! I have uploaded a new version of the patch which should fix the project hierarchy problems (simply by querying against parent_project_id, similar to [4427]). Again I had a trouble running the patch on my local meta-environment, so I hope that I didn't mangle your environment specific fixes in the diff.

[ocean90]

In 4929:

Translate/Rosetta: Add infrastructure for Cross-Locale PTEs.

Props akirk.
See #2000.

[ocean90]

@akirk I added you as a Cross-Locale PTE to ​https://translate.wordpress.org/projects/wp-plugins/nothing-much so you can do some further testing.

[akirk]

Great, thank you very much! I'll proceed with testing and will ping you back when I have a verdict.

[akirk]

No checkboxes for current translations by others

[akirk]

My new translation is current

[akirk]

I can make fuzzy translations current

[akirk]

I cannot modify translations by others that I have approved

[akirk]

When I submit a translations where a current owned by someone else exists, my new translation is waiting, not current

[akirk]

I've added a bunch of screenshots from my test. The only thing that I think doesn't work as expected is that I lose the right to modify/override a translation when I have approved it. For example if I approve a translation by accident there is no way to recover except to ask a PTE/GTE.

I'd therefore suggest to change the code so that you can also modify translations for which you are the one who validated them (i.e. user_id_last_modified trumps user_id). I have modified added a new diff for that change.

[ocean90]

In 5132:

Translate/Rosetta: Allow Cross-Locale PTEs to reject translations which they have approved.

Props akirk.
See #2000.

[akirk]

With the newest patch I can now reject a translation that I approved. I still cannot override translation approved by someone else which is by design.

[akirk]

@ocean90 Thanks! The fix worked, see the screenshot :)

[ocean90]

@akirk Great! I only had to add the if ( $current_translation ) {} check. What else is missing here?

[akirk]

Double waiting entries

[akirk]

@ocean90 thanks for catching that.

I've now completed the test with importing PO files and it successful, all of the above UI operations were reflected in the outcome.

The only thing that stood out for me was that I was able to import duplicate waiting translations: when importing as current for a current translation by someone else, the entry was correctly downgraded to waiting. Upon second import, the same happend but the duplicate waiting translation should have been dropped. I am not sure what actually caused this because the ​GlotPress core code should prevent that.