Handle files with the .php8 extension #263
Merged
Conversation
This is necessary in order for the phar to include symfony/polyfill-mbstring/Resources/mb_convert_variables.php8
swissspidy
reviewed
Feb 12, 2021
Interesting!
|
I think we could just bump the composer dependency instead. |
But they are not needed for this
schlessera
reviewed
Feb 15, 2021
.github/workflows/testing.yml
Outdated
| @@ -143,11 +143,11 @@ jobs: | |||
| - name: Prepare test database | |||
| if: steps.check_files.outputs.files_exists == 'true' | |||
| run: | | |||
| export MYQSL_HOST=127.0.0.1 | |||
| export MYSQL_HOST=127.0.0.1 | |||
schlessera
merged commit 3cbbf02
into
wp-cli:fix/gha-functional-tests-update
20 of 24 checks passed
20 of 24 checks passed
![@github-actions[bot]](https://webcf.waybackmachine.org/web/20210917060456im_/https://avatars.githubusercontent.com/in/15368?v=4){kind=small}
Functional - WP latest on PHP 8.0 with MySQL 8.0
Functional - WP latest on PHP 8.0 with MySQL 8.0
Details
Functional - WP trunk on PHP 8.0 with MySQL 8.0
Functional - WP trunk on PHP 8.0 with MySQL 8.0
Details
Functional - WP trunk on PHP 8.0 with MySQL 5.7
Functional - WP trunk on PHP 8.0 with MySQL 5.7
Details
Functional - WP trunk on PHP 8.0 with MySQL 5.6
Functional - WP trunk on PHP 8.0 with MySQL 5.6
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is necessary in order for the phar to include:
symfony/polyfill-mbstring/Resources/mb_convert_variables.php8
The text was updated successfully, but these errors were encountered: