Skip to content

/ scaffold-command

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of $EXTRA connection settings in install_db() #269

Merged
merged 1 commit into from Jul 4, 2020
Merged

Make use of $EXTRA connection settings in install_db() #269

merged 1 commit into from Jul 4, 2020

Conversation

@yukihiko-shinoda
Copy link
Contributor

@yukihiko-shinoda yukihiko-shinoda commented Jun 18, 2020

#249 forget to add $EXTRA parameters when check existing database.
Therefore, when we use install-wp-tests.sh to non default host DB like other Docker container,
we got error:

ERROR 2002 (HY000): Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2)
@yukihiko-shinoda
Fix bug that can't init non default host DB
ced5655
@yukihiko-shinoda yukihiko-shinoda requested a review from wp-cli/committers as a code owner Jun 18, 2020
@schlessera
schlessera approved these changes Jul 4, 2020
View changes
@schlessera schlessera added this to the 2.0.10 milestone Jul 4, 2020
@schlessera schlessera merged commit 4ce62ca into wp-cli:master Jul 4, 2020
4 checks passed
4 checks passed
@github-actions
Lint PHP files
Details
@github-actions
PHPCS
Details
@dep
DEP All dependencies are resolved
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schlessera schlessera changed the title Fix bug that can't init non default host DB Make use of $EXTRA connection settings in install_db() Jul 4, 2020
@yukihiko-shinoda yukihiko-shinoda deleted the yukihiko-shinoda:hotfix-extra branch Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlessera schlessera

Assignees
No one assigned
Labels
bug command:scaffold-plugin-tests
Milestone
2.0.10
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@yukihiko-shinoda @schlessera