Skip to content

/ eval-command

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve __FILE__/__DIR__ regex pattern #44

Merged
merged 4 commits into from Feb 6, 2020
Merged

Improve __FILE__/__DIR__ regex pattern #44

merged 4 commits into from Feb 6, 2020

Conversation

@schlessera
Copy link
Member

@schlessera schlessera commented Feb 5, 2020

The previous pattern would erroneously match a string like SOMETHING__FILE__.

See https://regex101.com/r/9hXp5d/4/ for the new pattern.
@schlessera
Improve __FILE__/__DIR__ regex pattern
ae2b105
@schlessera schlessera requested a review from as a code owner Feb 5, 2020
@schlessera schlessera changed the title Improve __FILE__/__DIR__ regex pattern Improve __FILE__/__DIR__ regex pattern Feb 5, 2020
@schlessera schlessera added this to the 2.0.6 milestone Feb 5, 2020
@schlessera schlessera mentioned this pull request Feb 5, 2020
Closed
2 tasks
schlessera added 3 commits Feb 5, 2020
@schlessera
Improve const wording
37a97ad
@schlessera
Do not strip $args, as it is needed
8e94899
@schlessera
Improve wording of $args description
a865193
schlessera added a commit that referenced this issue Feb 6, 2020
@schlessera
Merge pull request #44 from wp-cli/improve-file-dir-regex-pattern
d379732 
Improve `__FILE__`/`__DIR__` regex pattern
@schlessera schlessera merged commit d379732 into master Feb 6, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schlessera schlessera deleted the improve-file-dir-regex-pattern branch Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wp-cli/committers committers

Assignees
No one assigned
Labels
bug command:eval-file
Milestone
2.0.6
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@schlessera