Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IdnaEncoder: set maximum length as a constant #536

Merged
merged 1 commit into from Sep 17, 2021
Merged

IdnaEncoder: set maximum length as a constant #536

merged 1 commit into from Sep 17, 2021

Conversation

@jrfnl
Copy link
Member

@jrfnl jrfnl commented Sep 17, 2021

This value does not change during the request, so should be a constant.

Part of a PR series to address #513
@jrfnl
IdnaEncoder: set maximum length as a constant
e5a089b 
This value does not change during the request, so should be a constant.
@jrfnl jrfnl added this to the 2.0.0 milestone Sep 17, 2021
@jrfnl jrfnl requested a review from schlessera Sep 17, 2021
@schlessera schlessera merged commit 8fc622d into develop Sep 17, 2021
24 of 25 checks passed
@schlessera schlessera deleted the feature/513-2-max-length branch Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlessera schlessera

Assignees
No one assigned
Labels
Type: testing/chores/QA
Projects
None yet
Milestone
2.0.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@jrfnl @schlessera