Search block : Fix vertical alignment of search button text #32340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
the
[Block] Search
|
Size Change: +47 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
May 31, 2021
aristath
approved these changes
May 31, 2021
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depending on the height of the surround container the search button text can end up aligned to the top of the button which doesn't match the alignment of the input box text.
Fixes #29952
How to test
Check out PR and add a search block with outside button with blank canvas theme
Check that the text alignment on button matches the input box placeholder alignment
Screenshots
Before:
After: