Replace the Cancel workflow with native GitHub Action functionality. #32016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, GitHub introduced the `concurrency` option for ensuring that only a single job or workflow using the same concurrency group will run at a time. Currently, there is a Cancel workflow in the repo that aims to accomplish the same thing. However, when a backlog exists, the Cancel workflow for each commit does not run until its turn in the queue is reached. This can result in the backlog ballooning. The `concurrency` option in GitHub Actions runs a check when a workflow is queued, skipping the need to wait for an available runner to cancel old workflows.
youknowriad
approved these changes
May 19, 2021
|
Just a note that after this gets merged, it will only apply to workflow runs created after the first run of each workflow in each pull request. The |
|
Size Change: 0 B Total Size: 1.62 MB ℹ️ View Unchanged
|
desrosj
added a commit
that referenced
this pull request
Jul 2, 2021
…32016) * Replace the Cancel workflow with native GitHub Action functionality. Recently, GitHub introduced the `concurrency` option for ensuring that only a single job or workflow using the same concurrency group will run at a time. Currently, there is a Cancel workflow in the repo that aims to accomplish the same thing. However, when a backlog exists, the Cancel workflow for each commit does not run until its turn in the queue is reached. This can result in the backlog ballooning. The `concurrency` option in GitHub Actions runs a check when a workflow is queued, skipping the need to wait for an available runner to cancel old workflows. (cherry picked from commit 7b39dd7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently, GitHub introduced the
concurrencyoption for ensuring that only a single job or workflow using the same concurrency group will run at a time.Currently, there is a Cancel workflow in the repository that aims to accomplish the same thing. However, when a backlog exists, the Cancel workflow for each commit does not run until its turn in the queue is reached. This can result in the backlog ballooning.
The
concurrencyoption in GitHub Actions runs a check when a workflow is queued, skipping the need to wait for an available runner to cancel old workflows.This feature is currently in beta, but is stable enough to use.
This PR introduces
concurrencyto all workflows configured to run onpull_request. Incomplete workflow runs for previous commits in a PR will be cancelled automatically, whether they are running or queued.The Pull Request Automation workflow does not have
concurrencybecause those tasks need to run on each specific commit. This workflow typically runs in 10 seconds or less, so running every workflow is not problematic.For more information on this feature, see:
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).