Components: remove config() utility function, use values directly
#31646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
ciampo
changed the title
config function, use values directlyconfig() utility function, use values directly
diegohaz
approved these changes
May 11, 2021
packages/components/CHANGELOG.md
Outdated
| @@ -15,6 +15,7 @@ | |||
| ### Internal | |||
|
|
|||
| - `Flex`, `FlexBlock`, and `FlexItem` components have been re-written from the ground up ([#31297](https://github.com/WordPress/gutenberg/pull/31297)). | |||
| - `config()` utility function has been removed, in favour of accessing config values directly ([#31646](https://github.com/WordPress/gutenberg/pull/31646)) | |||
There was a problem hiding this comment.
I don't think we should add an entry here as it's not even touching any user-facing API.
There was a problem hiding this comment.
Makes sense! I deleted the entry in f6735f3
|
Hey @diegohaz , thank you for your review! I also went ahead and rebased to solve some conflicts. Since I don't have repo privileges yet, would you mind merging the PR? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the (redundant)
config()utility function, and instead access the config values directly. (part of what highlighted in #30503)How has this been tested?
trunk(e.g. by using Storybook)Screenshots
N/A
Types of changes
Refactor / cleanup
Checklist:
*.native.jsfiles for terms that need renaming or removal).