Fix Post Publishing Popover: Popover moves when certain dates are clicked #30298
+23
−5
Conversation
Fix Post Publishing popover glitch by changing the popover anchor ref to the containing div (PanelRow). Requires changing PanelRow to accept a forwarding ref.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
allilevine commentedMar 26, 2021
Description
Fix Post Publishing popover glitch by changing the popover anchor ref to the containing div (
PanelRow
). Requires changingPanelRow
to accept a forwarding ref.Alternatively, we can change
PanelRow
to accept a ref as a prop and include theforwardRef()
wrapper inPostSchedule
instead.Fixes #29899
How has this been tested?
PanelRow
component function correctly and don't require a ref.Screenshots
Types of changes
Bug fix:
PanelRow
component to accept a forwarding refPostSchedule
and assigns it toPanelRow
Dropdown
as an anchor ref and popover propChecklist:
*.native.js
files for terms that need renaming or removal).