Public API: Remove small APIs deprecated in WordPress 5.2 #30283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Performance
|
Size Change: -246 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
I think it's fine. I wonder if @annezazu has any thoughts on communication. A dev note seems like the most obvious step. Just checking usage (which might not work if the code is minified):
It'd be nice if this was built in to the plugin repo, some way to notify devs about removed APIs 😄 . |
In general, I agree. In this case, the question is whether -241 B is worth it. Anyway, it's a good way to start the discussion since in WordPress 5.3 the number of deprecations introduced is quite long. The safe bet would be keeping those deprecations in all the versions of WordPress that get security updates. |
youknowriad
added
the
Needs Dev Note
This might not be worth it on its own, its the accumulation that is worth it and instead of dropping all depreacations at once, it's better to spread over time, the older ones first. |
I agree with this and changes in this PR seem reasonable to me. What is the current process for this? First create a make.core post(dev note) and then remove or remove and then create the dev note? |
|
@ntsekouras The dev note happens by the time the WP RC approaches (and APIs freeze), so it's more: do the change, add the dev note label and write the post when the time comes. |
|
Just chiming in to say that I agree with a dev note approach as it's a predictable pathway. To be safe though, next week I'll reach out to the impacted plugin authors to let them know the change is coming so they can proactively prepare. |
|
Just confirming that all impacted plugin authors have been contacted today and directed to this GitHub issue! |
youknowriad
force-pushed
the
remove/5-2-deprecatins
branch
from
b3004b9
to
61571e8
Compare
|
Any approvals here :) |
talldan
approved these changes
Mar 30, 2021
|
Thanks :) |
gziolo
added
the
[Type] Breaking Change
gziolo
changed the title
15 tasks
youknowriad
removed
the
Needs Dev Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR raises the question of how long should it take to remove deprecated JS APIs. Unlike PHP these can't be supported forever because they have an impact on users, they keep useless Kbs around that combine impact performance.
In This PR I'm removing 5.2 deprecations which was released almost two years ago and since we had 5 major releases.
I think removing an old API should be done carefully by thinking of the impact of each API.
For the APIs removed in this PR particularly, I think the potential impact is negligible.