Fix toolbar for post excerpt warning #30280
Draft
Conversation
| return ( | ||
| <Warning>{ __( 'Post excerpt block: no post found.' ) }</Warning> | ||
| ); | ||
| } | ||
| return ( | ||
| <PostExcerptEditor |
youknowriad
Mar 26, 2021
Contributor
It seems that component is useless, we can just remove it and embed everything here?
It seems that component is useless, we can just remove it and embed everything here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Description
Fixes #30279
Moves the warning and wraps it inside a div with blockProps.
How has this been tested?
Follow the instructions in the issue.
Confirm that the warning now has a block toolbar; that the toolbar is still present when moved to top,
and that the block still works when placed in a post context for example query/loop.
Screenshots
Types of changes
Bug fix
Checklist: