Template part 'area' term - reword confusing 'type' terminology #29679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addison-Stavlo
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
6 tasks
Addison-Stavlo
requested review from
vindl,
jeyip,
david-szabo97,
mattwiebe,
Copons and
youknowriad
youknowriad
reviewed
Mar 9, 2021
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
youknowriad
approved these changes
Mar 9, 2021
Addison-Stavlo
force-pushed
the
fix/poorly-named-template-part-area-function
branch
from
cea5572
to
1b8d7a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renames some functions and docs to be less confusing as pointed out in #28410 (comment)
How has this been tested?
Test the site editor from a clean state. Verify things still work as expected: template parts still load from themes in their expected variations, updating and saving works, creating new template parts works, and there are no errors.
Screenshots
Types of changes
Checklist: