update "requires at least" value to 5.5 #29646
Conversation
of plugin file.
bph
changed the title
|
It's 5.6 now :) - #29701 |
|
I think it should be 5.6 now after @youknowriad merged #29701 |
| @@ -3,7 +3,7 @@ | |||
| * Plugin Name: Gutenberg | |||
| * Plugin URI: https://github.com/WordPress/gutenberg | |||
| * Description: Printing since 1440. This is the development plugin for the new block editor in core. | |||
| * Requires at least: 5.3 | |||
| * Requires at least: 5.5 | |||
youknowriad
Mar 10, 2021
Contributor
Do you think we can remove this entirely from here? I mean we already have this value defined in readme.txt isn't that enough?
Do you think we can remove this entirely from here? I mean we already have this value defined in readme.txt isn't that enough?
swissspidy
Mar 10, 2021
Member
Could add Tested up to here too, fwiw
Could add Tested up to here too, fwiw
gziolo
Mar 10, 2021
Member
See the last comment from @SergeyBiryukov:
If the headers are defined in both readme.txt and the main plugin file, precedence is given to the plugin file.
See the last comment from @SergeyBiryukov:
If the headers are defined in both readme.txt and the main plugin file, precedence is given to the plugin file.
SergeyBiryukov
Mar 10, 2021
•
Member
Do you think we can remove this entirely from here? I mean we already have this value defined in readme.txt isn't that enough?
Just noting that WordPress 5.8 aims to remove parsing readme.txt files from validate_plugin_requirements(), see https://core.trac.wordpress.org/ticket/48520. Per discussion with Otto, apparently that file should only have been used for the Plugin Directory and not for core, which should retrieve the data it needs from the main plugin file instead.
So I would suggest removing the Requires at least and Requires PHP headers from the readme.txt file, and keeping them only in the main plugin file. The Plugin Directory supports that too, see https://meta.trac.wordpress.org/ticket/4514.
Do you think we can remove this entirely from here? I mean we already have this value defined in readme.txt isn't that enough?
Just noting that WordPress 5.8 aims to remove parsing readme.txt files from validate_plugin_requirements(), see https://core.trac.wordpress.org/ticket/48520. Per discussion with Otto, apparently that file should only have been used for the Plugin Directory and not for core, which should retrieve the data it needs from the main plugin file instead.
So I would suggest removing the Requires at least and Requires PHP headers from the readme.txt file, and keeping them only in the main plugin file. The Plugin Directory supports that too, see https://meta.trac.wordpress.org/ticket/4514.
of plugin file.
Description
For plugin, the minimum requirement is 5.5 - it's already updated in the readme.txt but not in the plugin header of gutenberg.php
Checklist: