Size Change: +179 B (0%)

Total Size: 1.38 MB

_{compressed-size-action}

Thinking things through a little more... I am not sure that the title + area options should be so prominent in this context. It could easily mislead users into believing that any changes they make here are local to the parent template. I know the multi-entity save flow clears that up, but that might be a bit late...

Therefore, I'm thinking it might be better to move these options to the "Advanced" section:

The prominence could perhaps increase when editing a template part in isolation... something like:

But that is something to explore in more detail elsewhere (#29148).

This is possibly tangential, but should the html element change when you switch area? IE if I switch from Header to Footer, should the tag also change from <header> to <footer>?

Therefore, I'm thinking it might be better to move these options to the "Advanced" section:

IMO, this makes sense. This is more like a power-user feature anyway.

This is possibly tangential, but should the HTML element change when you switch area? IE if I switch from Header to Footer, should the tag also change from

to ?

I'd say this is OK if the current area matches the current tag. IE, area = header, tag = header, but I when switch to area = footer then tag becomes footer too. But if area = header, tag = div, then I switch to area = footer then tag should stay div.

Maybe that's too smart?

I'd say this is OK if the current area matches the current tag. IE, area = header, tag = header, but I when switch to area = footer then tag becomes footer too. But if area = header, tag = div, then I switch to area = footer then tag should stay div.

Maybe that's too smart?

I think it makes perfect sense to do exactly what you described.

Agreed with placing them in "Advanced". I think "area" needs some contextual explanatory text. Ideally we could also use the icons on the select element. Considering we might just have 3 or 4 canonical areas. It might make sense to list them as icons in a segmented control like the toolbar?

I'd say this is OK if the current area matches the current tag. IE, area = header, tag = header, but I when switch to area = footer then tag becomes footer too. But if area = header, tag = div, then I switch to area = footer then tag should stay div.

I think it makes sense to only set a tag based on the semantic area if a tagName attribute isn't set. So maybe we add an 'area default' to the tag name dropdown (and maybe add that default value in parens) that corresponds to the tagName being unset. Then when no tagname is set, we default to that value that corresponds to the semantic area.

We could use the existing icon buttons to create a simple segmented control:

Or we might create something more elaborate that can also be used in #29222

The helper text needs optimisation.

We could use the existing icon buttons to create a simple segmented control

It looks nice! Im not sure how many different 'areas' we plan to support in the future, but if we add a handful that second one with the large icons might become a bit weighty.

It could probably scale in rows – like the Inserter. But yeah, the simpler implementation might be the way to go to begin with.

The first one looks nice to me :)

I prefer it when the text with the area name is visible, or even the select list.
When the icons are used, I have to stop and think, trying to interpret what they mean. The tooltip can't replace that.

This is working well!
I like the default element tag based on area for when no tagName is set! However, it looks like as a result of that there is no way to set it as a div without the area being 'General'. I wonder if we should just add div to the list for elements now so users can have the power to override the area default with something non-semantic if there is ever any need.

I prefer it when the text with the area name is visible, or even the select list.

Maybe it makes sense to start with the dropdown list in this PR. And explore the icon designs in follow up?

• Moved controls to Advanced panel
• Added div as an option for HTML element
• Added a new "Default based on area" option for HTML elements
• Fixed tests

Maybe it makes sense to start with the dropdown list in this PR. And explore the icon designs in follow up?

I agree, let's keep them separate. Easier to review and discuss as well.