Size Change: -473 B (0%)

Total Size: 1.36 MB

_{compressed-size-action}

Whoah. A Sunday PR, and an impressive one at that! This is what I see:

A few things come to mind, that don't necessarily have to be part of this PR, but are inspired by how good this feels:

1. We should consider adding the block icon before the drag handle in select mode, so that when you lift the block off the page, the black chip that you then see matches in structure.
2. Should the black chip be the "select mode label"? I.e. when in select mode, the block toolbar is the same visual style as the floating chip?

Those are small nitpicks. But one thing I'd love to see, is that the entire block itself is the draggable area, in addition to the drag handle.

Right now when you click and drag on the block itself, nothing happens. So it seems like it could be the draggable handle instead. The primary tricky thing here is that the 2nd click on the selected block (i.e. click a selected block twice) should still go back to edit mode. So potentially we need to differentiate between ondrag and onclick, and only let the former actually drag.

Nice work! 👌

The branch seems to have all the commits from the try/menus-cleanup branch. I guess it wasn't based off of master?

I guess it wasn't based off of master?

Yes @talldan I was testing the new nav screen design PR and branched from it. I'll fix it but I wanted it to be visible b/c it really feels nice and I was curious if I'm biased :)