Skip to content

/ gutenberg

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling Full Site Editor blocks in classic themes #28744

Closed
priethor opened this issue Feb 4, 2021 · 9 comments
Closed

Enabling Full Site Editor blocks in classic themes #28744

priethor opened this issue Feb 4, 2021 · 9 comments
Assignees
@youknowriad
Labels
[Feature] Blocks [Feature] Full Site Editing [Feature] Themes [Type] Discussion [Type] Tracking Issue
Projects
WordPress 5.8 Must Haves

Comments

@priethor
Copy link
Contributor

@priethor priethor commented Feb 4, 2021 •
edited

With the upcoming inclusion of Full Site Editing in WP 5.8, many of the site-editing-oriented blocks currently enabled only with FSE should also be available to use in classic themes. The goal of this issue is to list all these blocks and determine whether each of them should also be enabled in non-FSE contexts.

Block Should be enabled without FSE? Related Issue
siteLogo ✅ #30406
siteTagline ✅ #30921
siteTitle ✅ #30918
templatePart ❌
query ✅ #26316, #30910
queryLoop ✅ #26316
queryPagination ❌
postTitle ✅
postContent ✅
postAuthor ✅
postComment ❌
postCommentAuthor ❌
postCommentContent ❌
postCommentDate ❌
postComments ❌
postCommentsCount ❌
postCommentsForm ❌
postDate ✅
postExcerpt ✅
postFeaturedImage ✅
postHierarchicalTerms ✅
postTags ✅
archiveTitle ❌
termDescription ❌
loginOut ✅

These blocks will be categorized in the block inserter as defined in #26639
@priethor priethor changed the title Enabling Full Site Editing blocks in non-FSE editors Enabling Site Editing blocks in non-FSE editors Feb 4, 2021
@skorasaurus
Copy link
Member

@skorasaurus skorasaurus commented Feb 4, 2021

There's an issue about this for the Query Block at #26316

@priethor priethor changed the title Enabling Site Editing blocks in non-FSE editors Enabling Full Site Editor blocks in classic themes Feb 4, 2021
@carolinan
Copy link
Contributor

@carolinan carolinan commented Feb 6, 2021

I would find the post excerpt useful.
A use case would be to have a custom excerpt showing in an archive, and then be used as lead text for the individual post.

@priethor
Copy link
Contributor Author

@priethor priethor commented Feb 12, 2021

All in all, it seems we kind of need most blocks except the "template part" block, which only makes sense in a Site Editing context.

@priethor
Copy link
Contributor Author

@priethor priethor commented Feb 12, 2021

As far as the Query block is concerned, we need to include all individual block variations built on top of the main Query block (e.g., "Posts block", "Pages block", which are the ones that end-users will be facing in the inserter, as well as Query block patterns (#28891)

@pbking pbking mentioned this issue Feb 17, 2021
Closed
@aristath aristath mentioned this issue Feb 22, 2021
Open
@carolinan carolinan mentioned this issue Mar 10, 2021
Merged
@mtias mtias mentioned this issue Mar 31, 2021
Closed
@mtias
Copy link
Contributor

@mtias mtias commented Apr 16, 2021

Updated the issue to exclude the "comments" related ones, since those make more sense for single page templates and need a bit more work.

@priethor priethor added this to 📥 To do in WordPress 5.8 Must Haves via automation Apr 16, 2021
@priethor
Copy link
Contributor Author

@priethor priethor commented Apr 19, 2021 •
edited

Added to the list the 3 new theme blocks that landed in 10.3 (Login/Out, Term Description, and Archive Title) for tracking purposes, although they don't seem to make a lot of sense with the Landing page scope of 5. Moreover, without #30679 the archive blocks can be used in any template even if they are not meant to.

@priethor
Copy link
Contributor Author

@priethor priethor commented Apr 20, 2021

Added the Login/Out as it can indeed be useful if added to a Widget Area thanks to the Widgets Editor project.

@priethor priethor linked a pull request that will close this issue May 3, 2021
Block Library: Stabilize some theme blocks for WP 5.8 release #31423
Merged
WordPress 5.8 Must Haves automation moved this from 📥 To do to ✅ Done May 4, 2021
@youknowriad youknowriad reopened this May 4, 2021
WordPress 5.8 Must Haves automation moved this from ✅ Done to 🏗️ In progress May 4, 2021
@youknowriad
Copy link
Contributor

@youknowriad youknowriad commented May 4, 2021

Reopening because there are some blocks left that we'd want to reconsider.

  • Terms blocks after #31422
  • LoginOut

@ntsekouras ntsekouras mentioned this issue May 4, 2021
Closed
@youknowriad youknowriad mentioned this issue May 5, 2021
Merged
WordPress 5.8 Must Haves automation moved this from 🏗️ In progress to ✅ Done May 5, 2021
@grappler
Copy link
Member

@grappler grappler commented Jul 23, 2021

The postAuthor block was not included in WP 5.8 #31983

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youknowriad youknowriad

Labels
[Feature] Blocks [Feature] Full Site Editing [Feature] Themes [Type] Discussion [Type] Tracking Issue
Projects
No open projects
WordPress 5.8 Must Haves
  
✅ Done
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Block Library: Stabilize some theme blocks for WP 5.8 release
Mark the loginout block as stable for 5.8 release
6 participants
@youknowriad @mtias @skorasaurus @grappler @carolinan @priethor