733: Add counts to filter links in the translation page. #741
Conversation
toolstack
changed the title
toolstack
changed the title
toolstack
force-pushed the
733-add-counts-to-filter-links
branch
from
8b73a4a
to
40a1142
|
Since we now have the counts, should we hide the links if the count is zero? |
gp-templates/translations.php
Outdated
| $filter_links[] = gp_link_get( | ||
| add_query_arg( $untranslated_filters, $url ), | ||
| // Translators: %d is the untranslated strings count for the current translation set. | ||
| sprintf( __( 'Untranslated [%d] (random)', 'glotpress' ), $translation_set->untranslated_count() ) |
ocean90
Jun 27, 2017
Member
We should use number_format_i18n() for numbers (and %s for the placeholder).
We should use number_format_i18n() for numbers (and %s for the placeholder).
ocean90
Jun 27, 2017
Member
Random was a separate link.
Random was a separate link.
|
I kind of like seeing the zeros, it make it clear there are no fuzzies/waiting/warnings :) It gives you a sense of accomplishment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Resolves #733.