732: Fix incorrect default in for_export() function for filters. #738
Conversation
for_translation() already handles the default so passing in a null is fine so don't bother setting the default in for_export().
| @@ -299,7 +299,7 @@ public function set_fields( $db_object ) { | |||
| } | |||
|
|
|||
| public function for_export( $project, $translation_set, $filters = null ) { | |||
ocean90
Jun 21, 2017
Member
The default of $filters should probably be changed to an array now since that's the expected type by for_translation().
The default of $filters should probably be changed to an array now since that's the expected type by for_translation().
toolstack
Jun 21, 2017
Author
Contributor
Makes sense I'll update it later.
I think there's a problem though with my solution so it may need an update, I'll verify it before I merge.
Makes sense I'll update it later.
I think there's a problem though with my solution so it may need an update, I'll verify it before I merge.
|
The PR simply inverts the problem, causing the "all current" export to break, closing this PR and opening a new one to resolve the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
for_translation() already handles the default so passing in a null is fine so don't bother setting the default in for_export().
Resolves #732.