Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover: Add custom unit support for height controls #20888

Merged
merged 31 commits into from
Mar 30, 2020
Merged

Cover: Add custom unit support for height controls #20888

Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
5ff8a7e
Add unit-control component
Mar 12, 2020
52bc8e5
Add G2 color values to color utils. Apply to UnitControl
Mar 12, 2020
b1676f5
Add numeric inputmode for UnitControl
Mar 12, 2020
c608b21
Add TODO note for NumberControl
Mar 12, 2020
cfb2f5a
Add NumberControl for better increment/decrement handling
Mar 12, 2020
8ba87a1
Refactor UnitControl and NumberControl. Add README files for components
Mar 13, 2020
c8641ea
Adjust UnitSelectControl rendering
Mar 13, 2020
9fd0b31
Improve integration of UnitControl with Cover Block
Mar 13, 2020
0c1b6b5
Adjust default minHeightUnit
Mar 13, 2020
2210d42
Fix default height for Cover block
Mar 13, 2020
125405f
Add add_theme_support for custom units
Mar 13, 2020
c411186
Adjust styles for UnitLabel
Mar 13, 2020
fc8e56d
Add unit tests for NumberControl. Update snapshot for UnitControl.
Mar 14, 2020
34a4bab
Abstract UnitControl to block-editor component
Mar 14, 2020
1dcc082
Refactor to remove getComputedSize. Set unitized height directly with…
Mar 15, 2020
50ed451
Improve reset values for UnitControl
Mar 15, 2020
8b43e60
Enable support for secondary parameters for `add_theme_support( 'disa…
Mar 17, 2020
7691e30
Add comments for unit filtering
Mar 17, 2020
a3998f3
Rename disable-custom-units to experimental-custom-units
Mar 19, 2020
2b6ea59
Provide return description for filterUnitsWithSettings util
Mar 19, 2020
34bafa0
Improve logic clarity of Cover minHeight style
Mar 19, 2020
23e79b7
Add dev notes for G2 color map
Mar 19, 2020
1b3a583
Default minHeightUnit of Cover to `px`
Mar 19, 2020
0a65b6d
Adjust colors to deep merge without mutation
Mar 20, 2020
8eaf5a6
Adjust label of Cover height control
Mar 25, 2020
455cb04
Remove unnecessary test comments from number-control test
Mar 27, 2020
94b3a85
Add tests for UnitControl
Mar 27, 2020
52882de
Update Storybook snapshots
Mar 27, 2020
95a7024
Remove default px value for minHeightUnit in Cover
Mar 30, 2020
fab4f91
Update PHP comments for line height and unit filters
Mar 30, 2020
0d8f031
Fix PHP lint issues
Mar 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Default minHeightUnit of Cover to px
  • Loading branch information
Jon Q committed Mar 30, 2020
commit 1b3a583fdb8cfc1ee33890792571f5f37e0f7dfa
3 changes: 2 additions & 1 deletion packages/block-library/src/cover/block.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@
"type": "number"
},
"minHeightUnit": {
"type": "string"
"type": "string",
"default": "px"
},
"gradient": {
"type": "string"
Expand Down