Skip to content

/ gutenberg

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global Styles: enqueue styles later so theme css can load first #34147

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Global Styles: enqueue styles later so theme css can load first #34147

wants to merge 1 commit into from
+11 −6

Conversation

@creativecoder
Copy link
Contributor

@creativecoder creativecoder commented Aug 18, 2021 •
edited

Description

Deenqueues and deregisters the 'global-styles' asset enqueued by Core, and reenqueues it on a later priority.

This allows theme css enqueued on the default priority to load first, so that a user's Global Style settings take precedence over theme css (particularly in the case of equal css selector weight).

Fixes #34141

Example of conflicts with themes: Automattic/themes#4435

How has this been tested?

Ensure that Global styles is loaded after the theme css on the page.

Screenshots

Screen Shot 2021-08-18 at 14 09 34

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
@creativecoder
Global Styles: enqueue later so theme css can load first
5095a9d
@creativecoder creativecoder self-assigned this Aug 18, 2021
This was referenced Aug 18, 2021
Open
Open
@jeyip
jeyip reviewed Aug 18, 2021
View changes
Copy link
Contributor

@jeyip jeyip left a comment •
edited

Testing

Requirements

  • With the blockbase theme, the global-styles-inline-css stylesheet is loaded after theme stylesheets
  • With the mayland blocks theme, the global-styles-inline-css stylesheet is loaded after theme stylesheets

Browsers

  • Edge
  • Firefox
  • Safari
  • Chrome

This makes sense to me 👍 Waiting for folks with more global styles experience to chime in before +1
@jeyip jeyip mentioned this pull request Aug 18, 2021
Open
1 of 7 tasks
@jffng jffng mentioned this pull request Aug 18, 2021
Open
@nosolosw
nosolosw requested changes Aug 19, 2021
View changes
Copy link
Member

@nosolosw nosolosw left a comment

The current behavior is how it's expected to work, so going to ask for more info on the issue before we go further with this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeyip jeyip

@nosolosw nosolosw

@spacedmonkey spacedmonkey

@scruffian scruffian

@jorgefilipecosta jorgefilipecosta

@desrosj desrosj

Requested changes must be addressed to merge this pull request.

Assignees

@creativecoder creativecoder

Labels
Global Styles [Status] Needs More Info
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Global Styles: consider loading user styles after theme styles
3 participants
@creativecoder @nosolosw @jeyip