wp-parsely: Only trigger warning when actually specifying a version via filter

[jblz]

Description

This is currently reporting an erroneous warning: "Invalid value configured via wpvip_parsely_version filter" even when a site is not overriding the filter. This only performs the check when it is.

This also includes a first pass at integration tests for the plugin. Since WordPress is already mostly loaded and the plugin is sourced prior to running phpunit test cases, we have to hook into the phpunit bootstrap file to vary behavior. We do that by leveraging environment variables specified on the test runner host machine.

These will be hooked into CI in a follow up PR.

Changelog Description

Plugin Updated: VIP Parse.ly Integration -- Fix spurious PHP Warning

We made some behind-the-scenes changes that will help customers try Parse.ly on their sites more easily.

Checklist

Please make sure the items below have been covered before requesting a review:

• This change works and has been tested locally (or has an appropriate fallback).
• This change works and has been tested on a Go sandbox.
• This change has relevant unit tests (if applicable).
• This change has relevant documentation additions / updates (if applicable).
• I've created a changelog description that aligns with the provided examples.

Steps to Test

1. Check out PR
2. Run docker
3. Execute each of the following. The tests should pass without visible PHP Warnings:
   • WP_TESTS_DIR=/tmp/wordpress-tests-lib ./bin/phpunit-docker.sh --file tests/parsely/test-mu-parsely-integration.php
   • WPVIP_PARSELY_INTEGRATION_TEST_MODE=option_enabled WP_TESTS_DIR=/tmp/wordpress-tests-lib ./bin/phpunit-docker.sh --file tests/parsely/test-mu-parsely-integration.php
   • WPVIP_PARSELY_INTEGRATION_TEST_MODE=filter_enabled WP_TESTS_DIR=/tmp/wordpress-tests-lib ./bin/phpunit-docker.sh --file tests/parsely/test-mu-parsely-integration.php
   • WPVIP_PARSELY_INTEGRATION_TEST_MODE=filter_and_option_enabled WP_TESTS_DIR=/tmp/wordpress-tests-lib ./bin/phpunit-docker.sh --file tests/parsely/test-mu-parsely-integration.php
   • WPVIP_PARSELY_INTEGRATION_PLUGIN_VERSION=2.5 WPVIP_PARSELY_INTEGRATION_TEST_MODE=filter_enabled WP_TESTS_DIR=/tmp/wordpress-tests-lib ./bin/phpunit-docker.sh --file tests/parsely/test-mu-parsely-integration.php
4. Execute the following:
   • WPVIP_PARSELY_INTEGRATION_PLUGIN_VERSION=2.4 WPVIP_PARSELY_INTEGRATION_TEST_MODE=filter_enabled WP_TESTS_DIR=/tmp/wordpress-tests-lib ./bin/phpunit-docker.sh --file tests/parsely/test-mu-parsely-integration.php
     • Tests should pass, but there should a PHP warning: PHP Warning: Invalid value configured via wpvip_parsely_version filter: 2.6 in /app/wp-parsely.php on line 59:

[pschoffer]

LGTM

[pauarge]

LGTM. Noting that tests run without explicitly setting WP_TESTS_DIR=/tmp/wordpress-tests-lib as per the PR description.

[jblz]

Thanks for the reviews!

Noting that tests run without explicitly setting WP_TESTS_DIR.. as per the PR description.

In my case, it didn't. I've got that specified in my .profile to a different location for an unrelated project and it erred out, so I included it in the command here for good measure.