danjm
Follow
danjm
Follow
Pinned
1,020 contributions in the last year
Less
More
Activity overview
Contributed to
MetaMask/metamask-extension,
MetaMask/metamask-filecoin-developer-beta,
MetaMask/controllers
and 5 other
repositories
Contribution activity
August 2021
Created 49 commits in 1 repository
Created 1 repository
- danjm/eth-ledger-bridge-keyring JavaScript
Created a pull request in MetaMask/metamask-extension that received 11 comments
Show advanced options, and hide radio buttons, for advanced gas settings users
This PR provides an improvement for users with the "Advanced gas controls" setting turned on. These users will be shown those options by default, a…
+82
−46
•
11
comments
Opened 24 other pull requests in 1 repository
MetaMask/metamask-extension
22
merged
2
closed
- Update copy on tooltip shown when gas suggests gas fees
- Dont default gas limit in gas popover when non is available on transaction params
- Allow advanced inline gas editing when there is an estimates unavailable error
- Allow submission of transactions with dapp suggested gas fees, while estimates are loading
- Allow editing custom gas while estimate is loading
- Improve flashing behaviour for loading gas estimates (on confirm screen)
- Ensure transaction activity log supports EIP-1559
- Fixes updates on the confirm screen.
- Allow max fee to be equal to max priority fee
- Use bignumber for number comparisons in useGasFeeInput
- Ensure that gas fee inputs fallback to tx params values if api is down
- Ensure that gas fee minimum errors show when api is down
- Fix legacy unapproved tx handling
- Ensure gas fees update in popover on poll for new values
- Rename effective gas price field to total gas fee
- Allows users to set a max priority fee below suggested, just showing a warning in that case
- Allow max priority fee to be below 1, and only require it to be greater than 0
- Update v10.0.0 changelog
- Master sync
-
Revert "Sync
masterwithdevelop(#11666)" - Ensure that gas price in popover updates when api provided estimate updates
- Show warning when network request for fee market estimates fails
- Fix display of inline estimates in advanced gas fee form
- Improves the autoupdating of estimates in the gas popover
Reviewed 52 pull requests in 3 repositories
MetaMask/metamask-extension
48 pull requests
- Update header on Send page to be more accurate
- Fix 'yarn setup' on M1 Macs
-
Sync
masterwithdevelop - Adding yarn scripts for changelog validation
- Using "Secret Recovery Phrase" throughout the onboarding flow
- Adding trezor files to standardSubtask (build system)
- Fix content cutoff issue (Mobile Sync View)
- Increase saliency of mobile sync warning
- Update v10.0.2 changelog
- Improve flashing behaviour for loading gas estimates (on confirm screen)
- Bump @metamask/controllers from 14.1.0 to 14.2.0
- Return an empty string when date is not provided [Date display utils]
- Integrate Tokenscontroller
- Integrating the TokenListController to Extension
- Update out of sync yarn.lock file
- Fix Sentry release configuration
-
Sync
masterwithdevelop - Version v10.0.0 RC
- Hide gasTiming on edit-gas-popover when form is in error
- Fix fee level content
- fix confirm transaction details to match spec
- Restore heartbeat to transaction confirmation, use isGasEstimatesLoading more broadly
- EIP-1559 - Ensure form always displays when there are errors
- Bump tar from 4.4.11 to 4.4.15
-
Update
eth-phishing-detectto latest version - Some pull request reviews not shown.