Menu Item placeholder: Show page label in setup state #33091
Projects
Comments
Worth clarifying that this issue is dependant on #32512 landing first. I think the wavy underline is worth trying — it's easy to tweak the thickness and shape of it, and if we ultimately find it not working, the same spot in the CSS can be used to show some other indicator, like a box, a dot, or anything else. |
17 of 38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jasmussen commentedJun 30, 2021
What problem does this address?
This is a sub-task oriented part of #32373. As discussed in that ticket, we need for the Navigation block to be able to accommodate a diverse range of opinionated patterns such as this one:
One part of that could be to indicate missing information through an underline, like so:
That missing information could be:
What is your proposed solution?
#32512 adds a wavy underline to menu items that have neither a URL nor a label. That checks off item 3 and 1 on the above list.
Item 2 still need addressing — that's the case where the label has already been configured, but the URL is still missing. In the following example markup, the first navigation link is missing both URL and label. The second navigation link is only missing the URL, but has "Services" pre-set as its label.
By allowing the label to be pre-set, this would allow pattern authors to create a wide range of highly useful block patterns where all you have to do is click an item and point at the URL:
In the above mockup, the URL dialog is also redesigned to surface both label and URL. This is ticketed separately in #30170,
The text was updated successfully, but these errors were encountered: