Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation: Allow Spacer Block #24028

Closed
shaunandrews opened this issue Jul 17, 2020 · 3 comments · Fixed by #29133
Closed

Navigation: Allow Spacer Block #24028

shaunandrews opened this issue Jul 17, 2020 · 3 comments · Fixed by #29133
Assignees
@tellthemachines
Labels
[Block] Navigation [Status] In Progress

Comments

@shaunandrews
Copy link
Contributor

@shaunandrews shaunandrews commented Jul 17, 2020

Allowing the Spacer block as an inner block of Navigation would let people create visual groupings of links. Something like this:

image

A horizontal option for the Spacer block could be useful in horizontal navigations, too:

image
@shaunandrews shaunandrews added this to Inbox in Navigation editor via automation Jul 17, 2020
@draganescu draganescu moved this from Inbox to Blocked in Navigation editor Jul 22, 2020
@draganescu
Copy link
Contributor

@draganescu draganescu commented Jul 22, 2020

This issue is currently blocked by the following aspects:

  • currently the spacer block only handles vertical spacing
  • adding horizontal spacing to the spacer block raises issues with fixed horizontal element sizes and responsiveness

There are also the related issues #23293 and #23294 which could eventually solve this better.

@noisysocks
Copy link
Member

@noisysocks noisysocks commented Aug 14, 2020

I think let's drop this for WP 5.6.

@draganescu
Copy link
Contributor

@draganescu draganescu commented Aug 19, 2020

I would love to have the spacer included in the list of supported blocks in building complex navigation, but it is not a requirement for the editor so I will remove this from the Navigation project.

@draganescu draganescu removed this from Blocked in Navigation editor Aug 19, 2020
@draganescu draganescu mentioned this issue Dec 8, 2020
Closed
37 tasks
@tellthemachines tellthemachines self-assigned this Feb 15, 2021
@tellthemachines tellthemachines added the [Status] In Progress label Feb 19, 2021
@tellthemachines tellthemachines mentioned this issue Feb 19, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tellthemachines tellthemachines

Labels
[Block] Navigation [Status] In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Spacer block width adjustable and add it to Navigation block WordPress/gutenberg
4 participants
@draganescu @shaunandrews @noisysocks @tellthemachines