Skip to content

/ gutenberg

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pattern insertion tracking issue #31153

Open
5 of 16 tasks
Tracked in #33094
priethor opened this issue Apr 23, 2021 · 3 comments
Open
5 of 16 tasks
Tracked in #33094

Pattern insertion tracking issue #31153

priethor opened this issue Apr 23, 2021 · 3 comments
Labels
[Feature] Inserter [Feature] Pattern Directory [Feature] Patterns [Type] Tracking Issue

Comments

@priethor
Copy link
Task lists! Give feedback
Contributor

@priethor priethor commented Apr 23, 2021 •
edited by ntsekouras

Insertion UI

  • Display patterns in a two-column masonry grid with improved category filtering #28312
  • Display block pattern options in a modal rather than placeholder state #31033
    • Depends on: Add a full screen modal component #28574
    • Precedes: Create a UI that suggests patterns that are contextual to the currently selected block #28736)
    • Deprecates: Expand view to view patterns in a larger overlay. #26905
  • Add pattern search to the slash inserter #26116
  • Improve layout shift caused by pattern previews loading in the inserter menus. #27494
  • Hide inserter sidebar when no patterns are registered #20867

Contextual suggestions (broader discussion in #27575)

  • Suggest Patterns in block placeholder states #28735
  • Block context: Suggests patterns that are contextual to the currently selected block #28736, #28309
    • Design Patterns to work with single pattern transforms #30631
  • Container context: Offer patterns that are contextual to the selected container, or the selected blocks container #28737
    • Size constraints: Make the block-pattern inserter spatially-aware #30210 (e.g. avoid large pattern in small columns)
  • Template context: Increase prominence of contextual patterns when template editing #28739
  • Template part context: Enable template part specific block patterns. #28802

Suggestion constraints

  • Patterns should not be displayed if their blocks are not allowed #23275
  • Remove block patterns if one or more of the blocks has been unregistered using unregisterBlockType #23803

Connection with w.org directory

  • Combine local and w.org search results for Inserter #28248
  • Load patterns from wordpress.org API #28800
@ramonjd
Copy link
Member

@ramonjd ramonjd commented May 17, 2021 •
edited

Looking for opinions here: would it make sense to be able to tell the block editor plugin not to register its own patterns or update core patterns?

Let's just say we want to be able offer our own library of patterns, or only those available in a WordPress install.

Other than keeping track of every block name that Gutenberg registers, and then manually unregistering them, how could we disable them?

I see two options (assuming the idea itself is sound):

  1. Add an apply_filters( 'register_gutenberg_patterns', true ) and apply_filters( 'update_core_patternscheck', true ) for example
  2. Standardize patterns names registered by the plugin so we can filter them out more reliably: currently we're registering query/* and social-links/shared-background-color.

I think it's especially important given the comment in the file:

 * Deactivate the legacy patterns bundled with WordPress, and add new block patterns for testing.

For experimental patterns, I think we should be able to opt-out.
@ramonjd ramonjd mentioned this issue May 17, 2021
Merged
@priethor
Copy link
Contributor Author

@priethor priethor commented May 17, 2021

Hi @ramonjd! Given this issue is more focused on the pattern insertion experience within post and template editors, I think it would be more effective to create its own issue to discuss this more in detail, as suggested in the related PR. In any case, I think your proposal makes sense, but I would love to hear @ntsekouras' opinion as well.
@ramonjd
Copy link
Member

@ramonjd ramonjd commented May 17, 2021

Thanks for the quick feedback @priethor! I'll do as you suggest, and create a new issue to direct discussion there. Sorry for hijacking this issue!
@mtias mtias mentioned this issue Jun 30, 2021
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Inserter [Feature] Pattern Directory [Feature] Patterns [Type] Tracking Issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@ramonjd @priethor