Add filter for get_locale() in remove_accents()

[akirk]

In the remove_accents() function, a filter for the call of get_locale() is needed for installations that want to make use of the special cases for hardcoded locales when those are different in their local installation.

[dd32]

Would it be better to have a parameter to the function? or to attach the custom-locale replacements via a filter of some kind?

I guess I'm just not clear on the use-case of this filter.

[akirk]

Not sure where you'd suggest to put a parameter?

For example, when creating a slug for a new post, the blog language is German but with a different locale than de_DE. So to have a way to rewrite the locale to the expected value (to make use of the special cases defined here), a filter (as in the patch) works as a simple solution.

Another option would be to remove the hardcoded de_DE and do that with a filter:

if ( apply_filters( 'locale_de_DE', 'de_DE' ) === $locale ) {
...
} elseif ( apply_filters( 'locale_da_DK', 'da_DK' ) === $locale ) {
...
}

To me the solution from the current patch seems a bit more flexible.

[SergeyBiryukov]

The filter needs to be documented as per the ​documentation standards.

[swissspidy]

In the meantime, one could probably do something like this:

<?php
function wp32939_change_locale( $title, $raw_title, $context ) {
  remove_filter( 'sanitize_title', 'wp32939_change_locale ' );
  add_filter( 'locale', function() { return 'de_DE';  } );
  return sanitize_title( $raw_title, '', $context );
}

add_filter( 'sanitize_title', 'wp32939_change_locale', 10, 3 );

[Dualcube]

We added a filter called update_locale_for_remove_accents which could be used to change the WP default locale for installations that want to make use of the special cases for hardcoded locales when those are different in their local installation.

[DrewAPicture]

Assigning ownership to mark the good-first-bug as "claimed".

[davidbaumwald]

This will need a @since refresh whichever cycle it ends up landing in.

[davidbaumwald]

This ticket still needs a refresh and review, and with 5.4 Beta 1 landing tomorrow, this is being moved to Future Release. If any maintainer or committer feels this can be included in 5.4 or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.